Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
rfj82982 created a review comment on a pull request on xcompact3d/Incompact3d
I think this is OK since it revert the `input.i3d` to reflect the one of a real case and not the one used for the test. The legacy inputs have been removed since no more relevant.
rfj82982 pushed 1 commit to UpdateTests xcompact3d/Incompact3d
- Remove Wind-Turbine. Still to Fix 7108570
rfj82982 pushed 43 commits to UpdateTests xcompact3d/Incompact3d
- Merge pull request #295 from xcompact3d/UpdateTests Update tests 9cc5569
- Fix HALO in WindTurbine simulator bf7a415
- Merge pull request #299 from xcompact3d/FixHalo Fix HALO in WindTurbine simulator 6cbe627
- Flush is now a statement not a subroutine e520e2e
- Replace unsupported tab characters with spaces f44f73b
- Merge pull request #300 from pbartholomew08/fixing-fortran Fixing fortran 2816c9a
- re-master particle module -- setup mpi-io for particles cbfc7f5
- update the two input files in example/MHD to full simulations bbca7ad
- add a mpi-io based read module to 1d array 54bc48d
- Merge pull request #302 from fangjian19/master update the two input files in example/MHD to full simulations 58673d0
- mpi io particle for upto 6 arrais e38a708
- done with mpi-io based partilce visu and checkpoint 50abde3
- particle module tested 5c0159d
- particle restart tested 6adbd50
- add particle inject frequency concept c8d9596
- particle tracking module developed and tested with two extra examples developed 78ba0b0
- nothing really b5ace0d
- remove a few lines according to the pull request review 5713d13
- change use only format back 84b88d4
- pass test with single precision, fixing conflict 4a0290c
- and 23 more ...
mathrack created a comment on an issue on xcompact3d/Incompact3d
Not really, catching this issue with gdd / valgrind is a bit difficult because it can change depending on the compiler and number of CPUs used... This issue was discussed in https://github.com/x...
slaizet created a comment on an issue on xcompact3d/Incompact3d
@mathrack would you have an input file for which you go into those special cases?
mathrack created a comment on an issue on xcompact3d/Incompact3d
Ok, I will start a draft for a fix shortly !
slaizet created a comment on an issue on xcompact3d/Incompact3d
The code does not support yet periodicity+stretching, but it will eventually :-) Anyway, even with non-periodic condition, the refinement procedure for the refined mesh is not great, hence why I th...
mathrack created a comment on an issue on xcompact3d/Incompact3d
If the code supports periodicity + stretching, we could fix the IBM issue with a modification of the stretching subroutine. However, this looks a bit complex and the `poisson_000` subroutine seems ...
slaizet created a comment on an issue on xcompact3d/Incompact3d
okay, I find some time to look into this one. What about changing slightly the stretching subroutine so that it has 3 arguments: N (domain size), YP (stretching on the velocity mesh), YPI (stretchi...
rfj82982 pushed 34 commits to master xcompact3d/Incompact3d
- re-master particle module -- setup mpi-io for particles cbfc7f5
- add a mpi-io based read module to 1d array 54bc48d
- mpi io particle for upto 6 arrais e38a708
- done with mpi-io based partilce visu and checkpoint 50abde3
- particle module tested 5c0159d
- particle restart tested 6adbd50
- add particle inject frequency concept c8d9596
- particle tracking module developed and tested with two extra examples developed 78ba0b0
- nothing really b5ace0d
- remove a few lines according to the pull request review 5713d13
- change use only format back 84b88d4
- pass test with single precision, fixing conflict 4a0290c
- particle module development done 9180cd4
- minor change on screen print b7d846e
- solved formatting issues 52a2df9
- fix initype_particle in module param e509e62
- fix intt_particles 6af9ada
- fix function pmax_mytype_array in mptool 6b2be1e
- improve mptool according to Cedric review 7dcaf69
- default test_particle off cc31b78
- and 14 more ...
rfj82982 created a review comment on a pull request on xcompact3d/Incompact3d
I guess this has been resolved as well
rfj82982 created a review comment on a pull request on xcompact3d/Incompact3d
I think this conversation has been resolved based on the following comment/conversation.
fangjian19 created a comment on a pull request on xcompact3d/Incompact3d
> LGTM. I tested with GNU/Intel/NVHPC and with GNU i have also used ADIOS2 and FFTW. Everything is working with the exception of NVHPC. There is a problem with `isnan` function that is not part of ...
rfj82982 created a review on a pull request on xcompact3d/Incompact3d
LGTM. I tested with GNU/Intel/NVHPC and with GNU i have also used ADIOS2 and FFTW. Everything is working with the exception of NVHPC. There is a problem with `isnan` function that is not part of th...
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
Pushed the change by spliiting the module into 3, but still keep everything in a single file.
mathrack created a review on a pull request on xcompact3d/Incompact3d
The PR should be limited to the (CMake) testing framework. If possible, please avoid updating / deleting input files here.
mathrack created a review on a pull request on xcompact3d/Incompact3d
The PR should be limited to the testing framework. If possible, please avoid updating / deleting input files here.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
The scope of the PR is to split the tests. I think updating the input files is outside of the scope of this PR.