Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
not really that big. change the name to max_n_particles to avoid confusion.
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
also sorted as above.
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
sorted. also improve the function to do the vector directly, instead of doing u,v,w separately .
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
there might be unactivated particle between 1 to size(parpack), the loop skip the unactivated particles. The loop is not continuous .
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
global search and replace done.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
I think the target attribute is needed if the subroutine contains something like `xxx => pa` or `xxx => pa%element`. This is probably not needed here.
pbartholomew08 created a review on a pull request on xcompact3d/Incompact3d
A few minor things, but looks good! In the examples where I could see values in the input where changing I tried to highlight model/physics values in case these have changed over time unintenti...
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Could you not just `foreach` over `list_files` instead of building a local copy?
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Minor typo: default
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
I think it can be useful to have these messages to confirm what tests are being generated. Perhaps we could make them more useful by `Add <MPI | MPI + Python> Test ${case}`?
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
ABL -> Cavity, it appears all CMakeLists.txt have "ABL" as their comment
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Is this intentional?
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Why leave out the wind turbine examples?
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Is this intentional?
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Is this intentional?
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Is this intentional?
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Is this intentional?