Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Does the `data` subdirectory not help keep this tidy?
pbartholomew08 created a review on a pull request on xcompact3d/Incompact3d
A few minor things, but looks good!
pbartholomew08 created a review on a pull request on xcompact3d/Incompact3d
A few minor things, but looks good!
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
it is designed that the particle type is only accessable within the module. the external routines will have to use subrotines inside the particle module to access particle.
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
not sure why decop2d abort is need in linintp, the current if else covers all cases not sure locality means here.
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
it is for test purposed, when the develop is done, move the particle test to full test
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
Or perhaps the trilinear interpolation function can do the error checking?
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
I think you can write a single/generic version of this using `class(*)` as the type of `var`.
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
I think you can write a single/generic version of this using `class(*)` as the type of `var`
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
replace `1.d-16` with `epsilon(1.0_mytype)`. I would add this to the local data of subroutine, e.g. ``` real(mytype), parameter :: eps = epsilon(1.0_mytyp) ``` or you could make this a module v...
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
use `1.0_mytype`
pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
I don't understand what you mean by this comment
Prathamesh-Banda opened an issue on xcompact3d/Incompact3d
Working of variable "xnu" in ALM method
Greetings, I am an MTech student and I am currently working on a code on ALM method in XCompact3D for a vertical axis wind turbine (VAWT). The code is modified for some endeffects model and s...
mathrack created a review on a pull request on xcompact3d/Incompact3d
I have suggested some modifications. I have not yet looked at `particle.f90`. I have an error with the following build command : ``` rm -rf ./build/ && FC=mpif90 cmake -S ./ -B ./build -DBUILD_T...
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please look at the input and output of the function `psum_integer` and `prelay`. Please describe the difference between both. It seems they are doing providing the exact same output.
fangjian19 created a comment on a pull request on xcompact3d/Incompact3d
The merge will be the basic framework of the particle tracking module. The particles are only massless fluid's tracker. But the module already contains some functions for heavy particles (current...
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
use epsilon(1._mytype) instead
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
done with the function.
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
changed it to epsilon(1._mytype)