Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

xcompact3d/Incompact3d

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
all data are supposed to be the same wise. The subroutine is used to dump data like velocity and coordinate, and the first colume is the dimension (1,2,3) and the second is the size of the array.. ...

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
I copied it from poisson.f90. Shall I also change that part too?

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

mathrack created a review comment on a pull request on xcompact3d/Incompact3d
I think there is no need for two functions doing the same job

View on GitHub

mathrack created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please add a statement when you resolve a conversation without any modification in the code

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
followed mathrack's solution. I missunderstood the point...

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
solved

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
add a new optional parameter var_size

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
It is to retune the number of the particles actually.

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
resolved using (*).

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

pbartholomew08 created a review comment on a pull request on xcompact3d/Incompact3d
I don't think the function as written can work, the array being reduced into is never allocated, consider the simplified version below with the Cray compiler: ``` ======= func_arr.f90 program te...

View on GitHub

pbartholomew08 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Without the optional parameter was also possible using `result(output)` and real(mytype) :: output(size(var))

View on GitHub

mathrack created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
I tested with single and double precision, and it works fine. But I have replaced it here.

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
done.

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
Sometimes, the size of the array is not explicit. I have added an optional parameter to handle it

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
done.

View on GitHub

fangjian19 created a review on a pull request on xcompact3d/Incompact3d

View on GitHub

fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
removed

View on GitHub

Load more