Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
particle_active added
fangjian19 created a comment on a pull request on xcompact3d/Incompact3d
> I have suggested some modifications. I have not yet looked at `particle.f90`. I have an error with the following build command : > > ``` > rm -rf ./build/ && FC=mpif90 cmake -S ./ -B ./build ...
mathrack created a comment on a pull request on xcompact3d/Incompact3d
There are plenty of unresolved comments, I think there is no need for a new review right now
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
not sure where this comes from. I copied and paster the original case-TGV file without any changes. I will try to overwrite the file with orginial.
fangjian19 created a review comment on a pull request on xcompact3d/Incompact3d
remove Particle-Tracking from test_full.
mathrack created a review on a pull request on xcompact3d/Incompact3d
I have suggested some modifications. I have not yet looked at `particle.f90`. I have an error with the following build command : ``` rm -rf ./build/ && FC=mpif90 cmake -S ./ -B ./build -DBUILD_T...
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please add a comment describing the objective of the function and the limitations (`yy1` and `yy2` must be 3D arrays with the same size)
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
I think the variable `var1` is not really needed
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Replace `1e-16_mytype` with `epsilon(xx)` ?
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
This is looking like a duplicate of `psum`
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please add a comment explaining why the printed data size is limited to the second dimension of the array
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
The code below is duplicated. Please refactor or use a dedicated subroutine.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
The code below is duplicated. Please refactor or use a dedicated subroutine.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Are we sure this statement based on the value of `mytype` is portable ?
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
The temporary variable `vta` seems useless. Is ti possible to use directly `table` ?
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Return statement is not needed at the end of a function / subroutine
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Unused variable `nvar` currently.
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please make the size of the output explicit so that it is easier to read / understand the function
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please make the size of the output explicit so that it is easier to read / understand the function
mathrack created a review comment on a pull request on xcompact3d/Incompact3d
Please use similar names, the current naming convention is not looking consistent compared with the other interfaces.
mathrack created a review on a pull request on xcompact3d/Incompact3d
I have suggested some modifications. I have not yet looked at `particle.f90`. I can not test the code. I am using the following build command : ``` rm -rf ./build/ && FC=mpif90 cmake -S ./ -B ./...
mathrack created a review on a pull request on xcompact3d/Incompact3d
I have suggested some modifications. I have not yet looked at `particle.f90`. I can not test the code. I am using the following build command : ``` rm -rf ./build/ && FC=mpif90 cmake -S ./ -B ./...