Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
schloerke opened a pull request on posit-dev/py-shiny
ci: Use latest deploy-pages
Saw we were behind on this version. Since it's internal only, I'm going to merge on successful GHA.
cpsievert created a comment on an issue on posit-dev/py-shiny
Interesting! Would you by chance be able to share a reproducible example?
cpsievert created a comment on an issue on posit-dev/py-shiny
Most inputs and other UI should return either a `ui.Tag` or `ui.TagList`. In the former case, you can mutate the attributes via `.attrs`: ```python >>> from shiny.ui import div >>> x = div() >>> x...
cpsievert created a comment on an issue on posit-dev/py-shiny
Hi @dreamtori, I'm having a hard time seeing/reproducing the issue you're seeing. Here is your code running on [shinylive](https://shinylive.io/py/editor/#code=NobwRAdghgtgpmAXGKAHVA6VBPMAaMAYwHsIA...
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
idk this feels a lot like the kind of comment that's explained by the code. `brand.color.palette` is only the brand's named colors and it's Sass variables come before `brand.defaults` because other...
JoseBlanca created a comment on an issue on posit-dev/py-shiny
Now I get it. Thanks. This behavior has been quite surprising to me because it worked during the development in Visual Studio Code and it failed when I tried to deploy the application. The applica...
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Ah, ok, that feels worth it. A mention of that capability in the Sass would be great.
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
Yup, came from here: https://github.com/quarto-dev/quarto-cli/blob/bf550cf7049f19d486b7410cb746b70367d0c359/src/core/sass/brand.ts#L31-L34 Happy to leave this for a follow-up PR.
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
Yup, came from here: https://github.com/quarto-dev/quarto-cli/blob/bf550cf7049f19d486b7410cb746b70367d0c359/src/core/sass/brand.ts#L31-L34 Happy to leave this for a follow-up PR.
gadenbuie pushed 1 commit to refactor/theme/from-brand posit-dev/py-shiny
- chore: add clarifying comment Co-authored-by: Carson Sievert <[email protected]> 85833f4
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
There's a good chance I copied this from the Quarto implementation. I'll check.
gadenbuie pushed 1 commit to refactor/theme/from-brand posit-dev/py-shiny
- chore: keep `-` in field names in brand Sass vars 01d6e8b
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
Great catch, thanks. You're right, I don't want these.
gadenbuie created a review comment on a pull request on posit-dev/py-shiny
The goal is to be able to say something like `$navbar-bg: $brand-blue`, which requires this order: ```scss $brand-blue: "#2233ff"; $navbar-bg: $brand-blue; ```
cpsievert created a review comment on a pull request on posit-dev/py-shiny
I would have expected the ordering here to be swapped (i.e., Bootstrap defaults first since they're the most specific). What's the rationale for the palette coming first?
cpsievert created a review comment on a pull request on posit-dev/py-shiny
```suggestion // * brand.defaults (Brand-defined Bootstrap defaults) ```
cpsievert created a review comment on a pull request on posit-dev/py-shiny
Maybe let's save this for another PR, but from a quick look, it seems `$body-secondary` and `$body-tertiary` don't exist?