Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
xermicus created a comment on a pull request on paritytech/revive
Ah okay, of course the tip bot isn't set up for this repo
xermicus created a review comment on a pull request on paritytech/revive
No. It would fail any differential test against EVM, wouldn't it?
xermicus created a review comment on a pull request on paritytech/revive
This should rather assert that the address space is either Storage or TransientStorage?
xermicus created a review comment on a pull request on paritytech/revive
This is not needed. We always return a register sized (xlen) pointer (because it contains the allocation pointer and no the storage pointer).
xermicus created a review comment on a pull request on paritytech/revive
The right place for this would be `fn build_storage_pointer_argument_store` on context, similar to the other helpers.
xermicus created a review comment on a pull request on paritytech/revive
```suggestion self.build_alloca(self.word_type(), "storage_value_pointer"); self.build_store(storage_value_pointer, self.word_const(0))?; ``` It looks to...
xermicus created a review on a pull request on paritytech/revive
Very nice catch, thanks! So this PR fixes two problems: The storage pointer values should not be truncated to the register size so that arbitrary storage keys work, not just ones that fall below...
xermicus created a review on a pull request on paritytech/revive
Very nice catch, thanks! So this PR fixes two problems: The storage pointer values should not be truncated to the register size so that arbitrary storage keys work, not just ones that fall below...
smiasojed created a comment on an issue on paritytech/revive
> @smiasojed is this issue still relevant? yes, I need to do still something with `evm.gasEstimates`. I will handle it when I have some time.
xermicus created a comment on an issue on paritytech/revive
@smiasojed is this issue still relevant?
xermicus opened an issue on paritytech/revive
Fix automatic import resultion
[See here](https://github.com/matter-labs/era-compiler-solidity/issues/98) for a detailed write up.
xermicus created a review on a pull request on paritytech/revive
You will also need to change the `inkwell` dependency to use [my branch here](https://github.com/TheDan64/inkwell/pull/549) (why is explained in the [related issue](https://github.com/paritytech/re...
xermicus created a review comment on a pull request on paritytech/revive
The custom LLVM needs a bootstrapping compiler. I think we only want the RISC-V target in the custom LLVM build we link into resolc. If we need to provide a bootstrapping LLVM build for our support...
athei created a review comment on a pull request on paritytech/revive
I told @wpt967 to de-pritotize this one since we are only supporting compilation REMIX for now. Until we have proper releases.
xermicus created a review comment on a pull request on paritytech/revive
Yes, when I tried cross compiling to musl using the current build script, resolc was still linked against `libstdc++` (and segfaulted with an LLVM panic message). See also this [comment in the rela...
alvicsam pushed 1 commit to release-ci paritytech/revive
- Update .github/Dockerfile-llvm Co-authored-by: Alexander Theißen <[email protected]> 36f9345
athei created a review comment on a pull request on paritytech/revive
```suggestion RUN bash -c ./build-llvm.sh ``` We probably need to modify the `build-llvm.sh` file to use other flags. AFAIK @xermicus discovered that some other flags are needed to it statical...
athei created a review comment on a pull request on paritytech/revive
```suggestion RUN apk add bash git cmake make ninja python3 ncurses-static curl ``` We should use the compilers from our custom built llvm. Especially gcc we don't want so we don't use it by a...
