Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
xermicus closed a pull request on paritytech/revive
standard json output: skip serializing keys instead of emitting a null object
@smiasojed I think we want to have this anyway? I also checked the ml repo, they skip over every option on null.
xermicus pushed 25 commits to cl/std-json-serialize paritytech/revive
- sync runtime with the pallet (#54) 287272b
- set chain_id in test runtime Signed-off-by: Cyrill Leutwiler <[email protected]> 066acc4
- Updated call semantics (#56) - Update pallet-revive dependency - Implement calls according to pallet-revive call se... 6585973
- [workflows] Add workflow for building revive in a debian container. Makefile: Add target 'install-revive' to build r... ad46e94
- Merge pull request #55 from wpt967/revive-debian-x86-build [workflows] Add workflow for building revive in a debian ... e8fcd61
- remove the test encoding option (#65) 77fe683
- implement immutable variables codegen Signed-off-by: xermicus <[email protected]> 0e6a6d1
- Revert "implement immutable variables codegen" This reverts commit 0e6a6d12c3ffa0612db7028b95bd78e492fde1e6. b344e0c
- deny clippy warnings by default (#73) 8b7fe8e
- implement immutable variables codegen (#70) d5d419c
- run signed_remainder test in differential mode (#75) 705d1d7
- remove system mode and request memoization Signed-off-by: Cyrill Leutwiler <[email protected]> e131eeb
- remove near calls Signed-off-by: Cyrill Leutwiler <[email protected]> 49d2157
- remove obsolete runtime builtins Signed-off-by: Cyrill Leutwiler <[email protected]> 6335c34
- Fix implementation for balance_of (#79) The balance_of syscall is now available in pallet-revive. - Fix balance_of ... d9842b5
- improve runtime api return value names (#81) adda5a0
- revive-runner: consider non-reverted transactions as success (#82) Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmai... e5233fc
- support solc 0.8.28 (#84) Signed-off-by: Cyrill Leutwiler <[email protected]> 92a1846
- disable sbrk and emulate EVM linear memory internally (#76) Signed-off-by: Cyrill Leutwiler <[email protected]... f0f344a
- bump polkavm and polkadot-sdk (#87) Signed-off-by: Cyrill Leutwiler <[email protected]> 5bf31db
- and 5 more ...
xermicus created a comment on an issue on paritytech/revive
I vote for just using `assembly_text` directly in remix.
smiasojed created a comment on an issue on paritytech/revive
> Why would 2. require a change in polkavm-disassembler instead bringing it to the right format directly in revive? Tying the PVM disassembler to this seems a bit stretched 😅 Now looking into it m...
xermicus created a comment on an issue on paritytech/revive
> Stemming from an internal discussion: > > * Provide what was requested; however > > * Provide default values for incompatible data (if requested) > > > We substitute any byte-c...
xermicus created a comment on an issue on paritytech/revive
Why would 2. require a change in polkavm-disassembler instead bringing it to the right format directly in revive? Tying the PVM disassembler to this seems a bit stretched 😅
smiasojed created a comment on an issue on paritytech/revive
Remix parses this before displaying and expect JSON format. We can not just substitute, because parsing will fail. In my opinion we have 2 options: 1. empty object 2. polkavm assembly in right f...
xermicus created a comment on an issue on paritytech/revive
Ah okay, I see where you are coming from. The problem is we are adding one more IR format. Remix is selling this as the "assembly" code. Which one would assume to be PVM assembly in our case. If we...
smiasojed created a comment on an issue on paritytech/revive
"evm.assembly contains assembly_text, so I think it is good to keep it. However, Remix displays `evm.legacyAssembly`, which is incorrect. The options are to either include PolkaVM assembly there...
xermicus created a comment on an issue on paritytech/revive
I reckon either `assembly` and `legacyAssembly` could as well be removed (i.e. replaced with the empty value). We will have maximum compat by keeping it. However I don't see what tools are supposed...
xermicus created a comment on an issue on paritytech/revive
Ah yeah, `assembly_text` is custom,[ it isn't a thing for `solc`](https://docs.soliditylang.org/en/v0.8.28/using-the-compiler.html#output-description).
xermicus created a comment on an issue on paritytech/revive
Legacy assembly is not to confuse with EVM bytecode. Legacy assembly is technically speaking on of our IRs. It can be passed through as-is.
smiasojed created a comment on an issue on paritytech/revive
> `evm.assembly` should contain the PolkaVM dissassembly. I think that we need to update polkavm-disassembler to be compatible with evm.legacyAssembly ``` "legacyAssembly": { ".c...
smiasojed opened a pull request on paritytech/revive
Set evm.deployedBytecode to the value of evm.bytecode
Please do not merge
smiasojed pushed 1 commit to sm/flags paritytech/revive
- Align deployedBytecode with bytecode cd6007a
athei created a comment on an issue on paritytech/revive
Because of course they do. They depend on every little detail :(
smiasojed created a comment on an issue on paritytech/revive
Remix uses `evm.bytecode` internally, so I think it is better to keep `bytecode` in sync with `deployedBytecode`.
xermicus created a comment on an issue on paritytech/revive
To me it'd also make sense to just provide the blob for both, the deploy code and runtime code? Because it is the same, it seems like we can just provide both for maximum compatibility.
xermicus pushed 1 commit to main paritytech/revive
- bump polkadot-sdk and polkavm (#94) Signed-off-by: xermicus <[email protected]> 995b115
xermicus closed a pull request on paritytech/revive
bump polkadot-sdk and polkavm
In the latest polkavm version blobs contain the length metadata
xermicus opened a pull request on paritytech/revive
bump polkadot-sdk and polkavm
In the latest polkavm version blobs contain the length metadata
smiasojed pushed 1 commit to sm/flags paritytech/revive
- Add evm.assembly and evm.gasEstimates flags 93b257e
xermicus created a comment on an issue on paritytech/revive
Ah okay I see. Thanks for clarifying. Yeah this is how I see in `solc` std json output directly: ` "metadata": "{\"compiler\":{\"version\":\"0.8.28+commit.7893614a\"},\"language\":\".....` ...
xermicus closed an issue on paritytech/revive
Incorrect JSON format of `solc_metadata`
Remix expects `contract.object.metadata` to be a string, but received a JSON object with `solc_metadata` inside as a string. ``` { contract: { "solc_metadata":"{\"compiler\":{\"version\":\"0.8....