Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
xermicus created a review comment on a pull request on paritytech/revive
This code is duplicated 3x. Since it is needed every time we lower functions it should be a helper on context instead.
xermicus created a review comment on a pull request on paritytech/revive
Why is this not a `let else` with an early return?
xermicus created a review comment on a pull request on paritytech/revive
Should prefer `if let` instead of `is_some()` followed by unwraps when we operate on optional values only if they are `Some` (noticed this in other places too).
athei created a review comment on a pull request on paritytech/revive
And where do you want to rename them? Here in the recompiler they obviously don't come up?
smiasojed opened an issue on paritytech/revive
Support deploy time linking
Add support for deploy time linking to compile this code correctly: ``` // SPDX-License-Identifier: GPL-3.0 pragma solidity >=0.7.0 <0.9.0; library Assert { function equal(uint256 a, u...
xermicus created a review comment on a pull request on paritytech/revive
Ok I see but `gas_limit` and `storage_limit` are terms that neither exist in EVM nor in Substrate :) I think that this would only increase the confusion.
athei created a review comment on a pull request on paritytech/revive
> True but I don't see how we can match 1 unit of gas with 1 unit of time (we may come close though) We are doing this: ` 1 gas = 1 ref_time = 1 picosecond of execution on the reference machine`
ermalkaleci created a review comment on a pull request on paritytech/revive
True but I don't see how we can match 1 unit of gas with 1 unit of time (we may come close though). Anyway renaming to `gas_limit` and `storage_limit` makes more sense to me.
athei created a review comment on a pull request on paritytech/revive
> I don't see how ref_time can be equal to gas. It is just how we define gas. This is where we incompatible to EVM. We use different gas values to allow making certain operations cheaper than o...
ermalkaleci created a review comment on a pull request on paritytech/revive
I propose we rename `ref_time` -> `gas_limit` and `proof_size` -> `storage_limit`
ermalkaleci created a review comment on a pull request on paritytech/revive
I don't see how `ref_time` can be equal to `gas`. 1 instruction means 1 unit of gas but it doesn't mean it's 1 picosecond. For brand new chains not depending on benchmarked `ref_time` it's easy bec...
xermicus closed an issue on paritytech/revive
Remove `sbkr` in favor of a static buffer
Dynamic allocations need to be metered in polkavm but this will be implemented later on. As an interim solution, we just use a static buffer instead. The exact size of this has still to be deter...
xermicus created a comment on an issue on paritytech/revive
We ultimately decided to have it as [metadata in the container](https://github.com/koute/polkavm/pull/188).
xermicus closed an issue on paritytech/revive
Embedded encoding of the bytecode length
We need to define a way to encode the length of the bytecode. Unlike with EVM, we need to know the offset of the constructor arguments for contract deployments. A possible solution would be to ...