Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ermalkaleci created a review comment on a pull request on paritytech/revive
What if we replace `ref_time` with `gas` and let runtime do conversion to Weight (`proof_size` is optional, unused for solidity). Other contracts build without revive using Weight will have to conv...
xermicus pushed 1 commit to main paritytech/revive
- tidy up the runtime API crate (#85) - remove unused runtime API imports and constants - move runtime api symbols in... 82ae22c
xermicus closed a pull request on paritytech/revive
tidy up the runtime API crate
- [remove unused runtime API imports and constants](https://github.com/paritytech/revive/pull/85/commits/9f5e9e0bdcd0f346a8d91bf36710282e258f9a97) - [move runtime api symbols into the revive-runti...
wpt967 created a review comment on a pull request on paritytech/revive
This is part of a commit on the main branch that was accidentally included.
xermicus pushed 1 commit to main paritytech/revive
- Makefile: remove duplicate workspace tests from the test target (#90) Signed-off-by: Cyrill Leutwiler <bigcyrill@hot... 20e3560
xermicus closed a pull request on paritytech/revive
Makefile: remove duplicate workspace tests from the test target
Also moved the clippy target around next to other test related targets
xermicus created a review comment on a pull request on paritytech/revive
maybe this goes away after a rebase against main?
xermicus created a review comment on a pull request on paritytech/revive
I don't get it - this is already in `paritytech:main`? :D
xermicus opened a pull request on paritytech/revive
Makefile: remove duplicate workspace tests from the test target
Also moved the clippy target around next to other test related targets
ermalkaleci created a comment on a pull request on paritytech/revive
@xermicus can you give [this](https://github.com/paritytech/polkadot-sdk/pull/6088) a review?
athei created a review comment on a pull request on paritytech/revive
Of course we can provide some additional API that just takes "gas". But this would just be optimization. It has exactly the same semantics as filling `0` as we do now.
xermicus created a review comment on a pull request on paritytech/revive
@ermalkaleci FWIW, in this PR it's fine to set it to remove the argument and set it to 0. The whole EVM gas vs. substrate weights problem is it's own topic.
xermicus created a review comment on a pull request on paritytech/revive
Yes you are right, for Solidity, ideally we just pass through what we get and let the pallet handle it. For other languages however this might be quite beneficial since they can just decide to not ...
athei created a review comment on a pull request on paritytech/revive
It cannot really be handled by pallet-revive alone. Since Solidity has no concept of it we have to assume some default limits for proof size and storage deposit limit. As of right now the default i...
ermalkaleci created a review comment on a pull request on paritytech/revive
I think we should replace weight (ref_time, proof_size) with just gas on revive. Solidity has no concept of PoV and all weight (substrate) related operations should be handled by pallet-revive (gas...
xermicus created a review comment on a pull request on paritytech/revive
Yeah the nature of immutables turns delegate calling by hash into a potential footgun. I'm in favor of changing it to take an address instead, it's not required for Solidity. Should it for some rea...