Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

paritytech/revive

xermicus created a review on a pull request on paritytech/revive

View on GitHub

athei created a review comment on a pull request on paritytech/revive
With immutables being a thing now does it even make sense to support delegate calling by code hash? We probably just want to remove it and just allow by contract address.

View on GitHub

athei created a review on a pull request on paritytech/revive

View on GitHub

xermicus created a review on a pull request on paritytech/revive
> Reworked 'set_debug_location' to make it easier to set debug locations. Thanks! I really like it. Half of the lines added are gone :) However there are still some inconsistencies I'd like to i...

View on GitHub

xermicus created a review comment on a pull request on paritytech/revive
> Ok that might not work at all. We might have to stick with the implication that we are done at the end here. (This was addressing my own comment I wrote earlier above) > Moved function debu...

View on GitHub

xermicus created a review comment on a pull request on paritytech/revive
Ok that might not work at all. We might have to stick with the implication that we are done at the end here.

View on GitHub

xermicus created a review on a pull request on paritytech/revive

View on GitHub

wpt967 created a review comment on a pull request on paritytech/revive
Moved function debug-info generation into `set_current_function`.

View on GitHub

wpt967 created a review on a pull request on paritytech/revive

View on GitHub

xermicus created a review comment on a pull request on paritytech/revive
I mean if this doesn't work. I might be missing something. But if we mismatch the code we emit with the function scope we emit, it smells like something should be broken. WDYT?

View on GitHub

xermicus created a review on a pull request on paritytech/revive

View on GitHub