Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
hanzei pushed 2 commits to MM-61119_support-packet mattermost/mattermost-plugin-github
Kshitij-Katiyar pushed 1 commit to MM-809 mattermost/mattermost-plugin-github
- [MM-809]: Fixed lint 794c5c4
raghavaggarwal2308 created a review comment on a pull request on mattermost/mattermost-plugin-github
@wiggin77 Replaced the print statement with a log. Please re-review
Kshitij-Katiyar pushed 1 commit to MM-809 mattermost/mattermost-plugin-github
- [MM-809]: Added proper error log in using github client 6d0bbe8
raghavaggarwal2308 created a comment on a pull request on mattermost/mattermost-plugin-github
@wiggin77 The [PR created by us](https://github.com/mattermost/mattermost-plugin-github/pull/838) is just fixing an issue in the [existing multiple org functionality on master (not released yet)](h...
wiggin77 created a review comment on a pull request on mattermost/mattermost-plugin-github
Why are we printing an error to stdout?
Kshitij-Katiyar pushed 10 commits to MM-809 mattermost/mattermost-plugin-github
- [MM-57194] Mark confidential settings as secrets (#811) 41ddb70
- Bump path-to-regexp and express in /e2e/playwright (#821) Bumps [path-to-regexp](https://github.com/pillarjs/path-to... 7d8ce87
- Bump elliptic from 6.5.5 to 6.5.7 in /webapp (#823) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.5... fda387b
- Bump path-to-regexp and express in /e2e/playwright/mock_oauth_server (#822) Bumps [path-to-regexp](https://github.co... bf6bee7
- [MM-794]: Returning proper JSON response from APIs (#831) * [MM-794]: returning proper JSON response from APIs * ... a54bc52
- [MM-813]: Fixed the issue of wrong name in subscription when PR is undrafted (#814) 267c219
- Bump cookie and express in /e2e/playwright (#835) Bumps [cookie](https://github.com/jshttp/cookie) to 0.7.1 and upda... 0cbfe9c
- Bump cookie and express in /e2e/playwright/mock_oauth_server (#836) Bumps [cookie](https://github.com/jshttp/cookie)... 6ba0bcd
- [MM-60676] Fix incorrect callback URL in setup flow (#827) * Fix incorrect callback URL in setup flow * Use url.Joi... af478ac
- Merge branch 'master' of github.com:mattermost/mattermost-plugin-github into MM-809 0ae7d94
AayushChaudhary0001 created a comment on a pull request on mattermost/mattermost-plugin-github
@Kshitij-Katiyar I was testing this PR and faced a new issue. While testing this PR without adding any organization, the data was not getting populated in the LHS and no error was received. On fur...
wiggin77 created a comment on a pull request on mattermost/mattermost-plugin-github
@Kshitij-Katiyar how does this PR relate to your recent PR handling orgs?
Kshitij-Katiyar pushed 6 commits to MM-742 mattermost/mattermost-plugin-github
- [MM-794]: Returning proper JSON response from APIs (#831) * [MM-794]: returning proper JSON response from APIs * ... a54bc52
- [MM-813]: Fixed the issue of wrong name in subscription when PR is undrafted (#814) 267c219
- Bump cookie and express in /e2e/playwright (#835) Bumps [cookie](https://github.com/jshttp/cookie) to 0.7.1 and upda... 0cbfe9c
- Bump cookie and express in /e2e/playwright/mock_oauth_server (#836) Bumps [cookie](https://github.com/jshttp/cookie)... 6ba0bcd
- [MM-60676] Fix incorrect callback URL in setup flow (#827) * Fix incorrect callback URL in setup flow * Use url.Joi... af478ac
- Merge branch 'master' of github.com:mattermost/mattermost-plugin-github into MM-742 302e11c
Kshitij-Katiyar opened a pull request on mattermost/mattermost-plugin-github
[MM-742]: Added a note about the label of pr/issue if the subscription is specific to a label
### Summary Added a note to the subscription message post about the label of pr/issue if the subscription is specific to a label ### Screenshots ![Screenshot from 2024-09-25 17-58-16](https://...
Kshitij-Katiyar created a branch on mattermost/mattermost-plugin-github
MM-742 - GitHub plugin for Mattermost
Kshitij-Katiyar created a review comment on a pull request on mattermost/mattermost-plugin-github
@wiggin77 Moving the org check directly into the params map definition and changing `if org != "" {` to `if org == "" {` would complicate handling cases where the org string is empty (possibly...
wiggin77 created a review comment on a pull request on mattermost/mattermost-plugin-github
(I'm assuming `org != ""` is the most frequent case.)
wiggin77 created a review comment on a pull request on mattermost/mattermost-plugin-github
@Kshitij-Katiyar this is an improvement in that the map is not recreated for each org. However it does not address the issue I mentioned above. The three items that get overwritten in the case of ...
Kshitij-Katiyar created a review comment on a pull request on mattermost/mattermost-plugin-github
Hey @wiggin77, I have implemented your suggestions and refactored the logic of adding the org check to the query. Please have a look.
Kshitij-Katiyar pushed 1 commit to MM-874 mattermost/mattermost-plugin-github
- [MM-874]: Moved the org restricted fetching of data code above the unrestricted data fetch 828c23d
wiggin77 created a review comment on a pull request on mattermost/mattermost-plugin-github
Seems like the most frequent scenario is with an org, and that path always sets the `queryParamOpenPRQueryArg` etc twice. Can we reverse it so the most common case is the most performant?