Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
vasylhnatiuk created a review comment on a pull request on mate-academy/py-cinema-visit
```suggestion self, movie_name: str, customers: list[Customer], cleaning_staff: Cleaner ```
vasylhnatiuk created a review comment on a pull request on mate-academy/py-cinema-visit
```suggestion customers: list[dict], hall_number: int, cleaner: str, movie: str ```
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your code meets all the task requirements and constraints perfectly. Each class and function is implemented correctly, and everything works as expected. Keep up the excellent work! 😊 ...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your implementation meets all the task requirements and constraints perfectly. Each class and function is well-structured and performs as expected. Keep up the excellent work! 😊 ✨ Ple...
kram3ko created a review on a pull request on mate-academy/py-cinema-visit
moved parameters for each line.
oliasymak24 created a review comment on a pull request on mate-academy/py-cinema-visit
Each parameter must be from new line
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The function signature should match the task description. The parameter `cleaner` should be named `cleaner_name` and `number` should be `hall_number` to match the task requirements.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `sell_product` method requires both `customer` and `product` parameters. Update the call to `CinemaBar.sell_product(customer, customer.food)` to pass the correct arguments.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The generator expression `(customer.watch_movie(movie_name) for customer in customers)` does not execute the `watch_movie` method. It should be replaced with a loop: `for customer in customers: cus...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The print statement should use the `product` parameter instead of `customer.food`. Update it to `print(f"Cinema bar sold {product} to {customer.name}.")`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `sell_product` method should take an additional parameter `product` as per the task description. Update the method signature to `def sell_product(customer: Customer, product: str) -> None:`.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
**** Thank you for your hard work on this task! 😊 While your solution is on the right track, there are a few critical issues that need to be addressed to meet the core requirements: 1. **Paramete...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `CinemaBar` class should be instantiated before calling the `sell_product` method. Change `cb = CinemaBar` to `cb = CinemaBar()` to create an instance of the class.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job on implementing the solution! 🎉 Your code meets the task requirements and constraints, and all classes are correctly implemented. However, there's a small issue in the `cinema_visit` func...
