Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
### Review Summary Great effort on your submission! π While your code doesn't fully meet the task requirements and constraints, the decision to approve is made to help you move forward with your l...
ProgrammerYaroslav opened a pull request on mate-academy/py-cinema-visit
Solution
`# app/people/customer.py class Customer: def __init__(self, name: str, food: str) -> None: self.name = name self.food = food def watch_movie(self, movie_name: str) -...
ProgrammerYaroslav closed a pull request on mate-academy/py-cinema-visit
Solution
`from app.people.customer import Customer class CinemaBar: @staticmethod def sell_product(customer: Customer, product: str) -> None: print(f"Cinema bar sold {product} to {cu...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Your submission has some critical issues that need to be addressed before it can be approved. The main concerns are related to the implementation of the classes and methods as per the task requirem...
ProgrammerYaroslav opened a pull request on mate-academy/py-cinema-visit
Solution
`from app.people.customer import Customer class CinemaBar: @staticmethod def sell_product(customer: Customer, product: str) -> None: print(f"Cinema bar sold {product} to {cu...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! π Your code meets all the task requirements and constraints perfectly. The implementation of classes and functions is spot on, and everything is working as expected. Keep up the excellen...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Your implementation of the cinema system is well-structured and meets the task requirements. π The classes `Customer`, `Cleaner`, `CinemaHall`, and `CinemaBar` are correctly implemented, with metho...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The method `movie_session` should be called on the `hall_num` instance, not on the `CinemaHall` class. Change `CinemaHall.movie_session(...)` to `hall_num.movie_session(...)`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The method `clean_hall` should be called on the `cleaning_staff` instance, not on the `Cleaner` class. Change `Cleaner.clean_hall(cleaning_staff, self.number)` to `cleaning_staff.clean_hall(self.nu...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The method `watch_movie` should be called on the `customer` instance, not on the `Customer` class. Change `Customer.watch_movie(customer, movie_name)` to `customer.watch_movie(movie_name)`.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Thank you for your hard work on this project! π There are a few critical issues that need to be addressed to ensure the code functions as expected. Specifically, method calls for `watch_movie`, `cl...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! π Your code meets all the task requirements and constraints. Everything is well-implemented, and no changes are needed. Keep up the excellent work! π β¨ Please rate this review in the Pl...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `sell_product` method of `CinemaBar` should be called as a static method. According to the task description, you should not create an instance of `CinemaBar`. Instead, call it directly using `C...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job on implementing the `cinema_visit` function! π The code meets the task requirements and constraints, and you've correctly used class imports and method calls. Just remember to call the `s...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Your code implementation is spot on and meets all the task requirements! π Each class and function is well-structured and aligns perfectly with the task description. Keep up the great work, and con...
vsmutok created a review comment on a pull request on mate-academy/py-cinema-visit
```suggestion class Cleaner: def __init__(self, name: str) -> None: self.name = name def clean_hall(self, hall_number: int) -> None: ``` If you can write it in one line, it'...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `CinemaBar` class should be used without creating an instance, as it only contains a static method. You should call the static method directly using the class name, like `CinemaBar.sell_product...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
### Review Summary Great effort on your submission! π While your code is on the right track, there are a few critical issues that need attention to fully meet the task requirements: 1. **Incorrec...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `CinemaBar` class should be used without creating an instance, as it only contains a static method `sell_product`. You can call `CinemaBar.sell_product(...)` directly.