Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The function definition line is too long. According to the checklist, each parameter should be placed on a new line if the line is too long .
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
**** Hello! 😊 It looks like there are a few critical issues that need to be addressed before we can approve the pull request: 1. **Incorrect Use of `CinemaBar` Class**: The `CinemaBar` class shou...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Sorry, the pull request review was unsuccessful for the following reasons: > [!WARNING] > **The test task has already been approved.** > <sub>*[CODE: 9]*</sub> If the issue is within your contr...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `cleaner` parameter should be of type `Cleaner`, not `str`, as per the task requirements. Update the type annotation to `Cleaner`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `customers` parameter should be a list of `Customer` instances, not a string. Update the type annotation to `List[Customer]`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `cleaning_staff` parameter should be a `Cleaner` instance, not a string. Update the type annotation to `Cleaner`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `customer` parameter should be of type `Customer`, not `str`, as per the task requirements. Update the type annotation to `Customer`.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job on implementing the solution! 🎉 Your code meets the task requirements, and the overall structure is well-organized. However, there are a few critical issues that need attention: 1. **Cin...
Ngayka created a review on a pull request on mate-academy/py-cinema-visit
changed all parentheses according to pip rules
Ngayka created a comment on a pull request on mate-academy/py-cinema-visit
all corrected. I will gratefull for new review
Ngayka created a comment on a pull request on mate-academy/py-cinema-visit
Changes have been made. I will be grateful for a repeat review!
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The use of triple quotes for the f-string is unnecessary here. You can use single or double quotes for single-line strings: `print(f'{self.name} is watching "{movie}".')`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `sell_product` method should be called with `product` as the first argument and `customer` as the second. The current call is correct, but ensure that it matches the method signature: `CinemaBa...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
Similar to line 14, the use of triple quotes is unnecessary for this single-line string. Consider using single or double quotes: `print(f'"{movie_name}" ended.')`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The use of triple quotes for the f-string is unnecessary here. You can use single or double quotes for single-line strings: `print(f'"{movie_name}" started in hall number {self.number}.')`.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job on addressing the previous issues and refining your code! 🎉 The `CinemaBar` class and its method calls are now correctly implemented, and the module paths are consistent with the project ...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Sorry, the pull request review was unsuccessful for the following reasons: > [!WARNING] > **The test task has already been approved.** > <sub>*[CODE: 9]*</sub> If the issue is within your contr...
Ngayka created a review on a pull request on mate-academy/py-cinema-visit
all mistakes has been corected
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Sorry, the pull request review was unsuccessful for the following reasons: > [!WARNING] > **The test task has already been approved.** > <sub>*[CODE: 9]*</sub> If the issue is within your contr...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Your code is almost there, but there are a few critical issues that need addressing before we can approve it. 😊 1. **Class Definition in `bar.py`:** The `Customer` class should be moved to `custom...
Ngayka opened a pull request on mate-academy/py-cinema-visit
all tasks are completed. imported all modules,
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `movie_session` method should be called on an instance of `CinemaHall`, not directly on the class. You should create an instance of `CinemaHall` and then call `movie_session` on that instance.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job on implementing the task requirements! 🎉 The code is well-structured and meets the core functionality as described. Just a small note: ensure that the `movie_session` method is called on ...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Sorry, the pull request review was unsuccessful for the following reasons: > [!WARNING] > **The test task has already been approved.** > <sub>*[CODE: 9]*</sub> If the issue is within your contr...
