Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your code meets all the task requirements and constraints perfectly. Each class and function is well-implemented, and everything works as expected. Keep up the excellent work! 🚀 ✨ Ple...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your code meets all the task requirements and constraints perfectly. Each class and function is implemented correctly, and everything works as expected. Keep up the excellent work! 🚀 ...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `CinemaHall` instance is created but not used. You need to call the `movie_session` method on this instance to perform the movie session actions, as described in the task requirements.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job on implementing the task! 🎉 The code meets the requirements and constraints, with only a minor issue regarding the `CinemaHall` instance in `main.py`. Remember to call the `movie_session`...
kram3ko opened a pull request on mate-academy/py-cinema-visit
Task Cinema visit. imports, packages and modules.
Created package `cinema` with modules: `bar`, `hall`. Created package `people` with modules: `customer`, `cinema_staff`. Implemented functionality in `main.py` to handle cinema visit logic.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job on implementing the classes and functions as per the task description! 🎉 Everything seems to be working correctly, and your code meets the core requirements. Keep up the good work and con...
VladikVll opened a pull request on mate-academy/py-cinema-visit
Solution
Solution for py-cinema-visit
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `watch_movie` method should have a return type hint of `None` since it does not return any value. Update the return type hint to `-> None`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `__init__` method should not have a return type hint. Remove `-> str` as constructors do not return a value.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `__init__` method should not have a return type hint. Remove `-> str` as constructors do not return a value.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `clean_hall` method should have a return type hint of `None` since it does not return any value. Update the return type hint to `-> None`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The type hint for the `cleaner` parameter is incorrect. It should be a `Cleaner` instance, not a `str`. Update the type hint to `Cleaner`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The type hint for the `customers` parameter is incorrect. It should be a list of `Customer` instances, not a `str`. Update the type hint to `List[Customer]`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The type hint for the `cleaning_staff` parameter is incorrect. It should be a `Cleaner` instance, not a `str`. Update the type hint to `Cleaner`.