Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Sorry, the pull request review was unsuccessful for the following reasons: > [!WARNING] > **The test task has already been approved.** > <sub>*[CODE: 9]*</sub> If the issue is within your contr...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
Consider using a more specific type for the `customer` parameter instead of `Any`, if possible. This will make the code more readable and help with type checking.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Your code is well-structured and meets all the task requirements! 🎉 The only suggestion is to consider using a more specific type for the `customer` parameter instead of `Any` in the `CinemaBar` cl...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `clean_hall` method should be called with the `hall_number` parameter. Ensure you pass the hall number to this method as required by the task description.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `movie_session` method of `CinemaHall` should be called with the parameters: `movie_name`, `customers` (list of `Customer` instances), and `cleaning_staff` (a `Cleaner` instance). Ensure you pa...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `CinemaBar` class should be used to sell products to customers. According to the task description, you should call the static method `sell_product` of `CinemaBar` for each customer, passing the...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Thank you for your hard work on this project! However, there are a few critical issues that need to be addressed to meet the task requirements. The `cinema_visit` function currently does not correc...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your code meets all the task requirements and constraints perfectly. Each class and function is implemented correctly, and everything is working as expected. Keep up the excellent work...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `sell_product` method should be called as a static method. Ensure that `CinemaBar` class has `sell_product` defined as a static method using the `@staticmethod` decorator.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
There is a syntax error in the string formatting. The quotes around `{movie}` are incorrectly placed. You should escape the inner quotes or use a different quoting style for the string. For example...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The import path for `Customer` is incorrect. It should be `from app.people.customer import Customer` to match the directory structure.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The import path for `Cleaner` is incorrect. It should be `from app.people.cinema_staff import Cleaner` to match the directory structure.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `Customer` class is not imported in this file. You need to import it to avoid a NameError. According to the task requirements, you should use absolute imports, so the import statement should lo...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `sell_product` method should be defined as a static method. You can do this by adding the `@staticmethod` decorator above the method definition. This is required by the task description, which ...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Thank you for your hard work on this pull request! 😊 However, there are a few critical issues that need to be addressed before we can approve it: 1. **Static Method Requirement**: The `sell_produc...
vsmutok created a review comment on a pull request on mate-academy/py-cinema-visit
please don't change tests
vsmutok created a review comment on a pull request on mate-academy/py-cinema-visit
please don't change tests
vsmutok created a review comment on a pull request on mate-academy/py-cinema-visit
you can use list comprehension here
vsmutok created a review comment on a pull request on mate-academy/py-cinema-visit
please don't change tests