Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `sell_product` method of `CinemaBar` should be called as a static method, not on an instance. You should use `CinemaBar.sell_product(visitor.food, visitor)` directly without creating an instanc...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job on implementing the `cinema_visit` function! 🎉 The code meets the task requirements and constraints effectively. Just a small tweak is needed: ensure that the `sell_product` method of `Ci...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your code meets all the task requirements and constraints perfectly. Each class and function is implemented correctly, and everything works as expected. Keep up the excellent work! 🚀 ...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The parameter `movie_name` in the `movie_session` method call should be `movies_name` to match the parameter name defined in the `CinemaHall` class.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `hall_number` parameter in the constructor is redundant because the `clean_hall` method already accepts a `hall_number` parameter. Consider removing `hall_number` from the constructor to simpli...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `print` statement currently outputs the `Customer` object directly, which may not display the customer's name as intended. You should modify the statement to access the `name` attribute of the ...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The parameter `customer` should be renamed to `customers` to accurately reflect that it is a list of customer dictionaries, as per the task description.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job on your submission! 🎉 While your implementation is mostly correct, there are a few areas that need attention to fully align with the task requirements: 1. **Parameter Naming in `movie_se...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `hall_number` parameter should be an integer, not a `CinemaHall` instance. Update the instantiation of `CinemaHall` to use the correct type.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `movie_name` parameter in `movie_session` should be a string, not a `CinemaHall` instance. Ensure that the `movie` parameter is passed as a string.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `sell_product` method call has a parameter naming issue. The correct parameter name should be `customer` instead of `customer` to match the method definition in `CinemaBar`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The parameter types in the function signature are incorrect. `customers` should be a list of dictionaries, `hall_number` should be an integer, and `movie` should be a string. Update the function si...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The placeholder in the formatted string should use `customer.name` instead of `customers` to correctly display the customer's name. Ensure the parameter name is corrected to `customer` as well.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The parameter name `customers` should be `customer` to match the task description, which specifies that the `sell_product` method takes a single `Customer` instance as `customer`.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Thank you for your hard work on this project! However, there are a few critical issues that need to be addressed before we can approve the pull request. Specifically, the parameter naming and type ...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your implementation meets all the task requirements and constraints perfectly. Each class and function is well-defined and performs as expected. Keep up the excellent work! 😊 ✨ Please...
pavlopro created a review on a pull request on mate-academy/py-cinema-visit
Do not modify files in test folder
