Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
migueloller created a review comment on a pull request on makeswift/vibes
You could do something like this: ```ts return ( <Suspense fallback={<Skeleton />}> {mapStreamable(streamableReview, reviews => reviews.length === 0 ? <EmptyState /> : <ReviewsList revi...
migueloller created a review comment on a pull request on makeswift/vibes
If we're using `await` there's no need to use `mapStreamable` since we can just do this: ```ts const reviews = await streamableReviews ``` That being said, using `mapStreamable` should remo...
migueloller created a review on a pull request on makeswift/vibes
Looks good 👍🏻 By the way, looks like you're still opening this PR from a fork instead of a branch from the repo, which is resulting in Vercel deployments not running automatically and asking fo...
migueloller created a review on a pull request on makeswift/vibes
Looks good 👍🏻 By the way, looks like you're still opening this PR from a fork instead of a branch from the repo, which is resulting in Vercel deployments not running automatically and asking fo...
jorgemoya created a review comment on a pull request on makeswift/vibes
I think exporting the Skeleton is still a great idea for those use cases when users want to stream in the entire data.
jorgemoya created a review comment on a pull request on makeswift/vibes
This is only needed because I resolve reviews to know if I want to render empty component or not. See above.
jorgemoya created a review comment on a pull request on makeswift/vibes
Not sure what is the naming convention for internal components.
jorgemoya created a review comment on a pull request on makeswift/vibes
I tried to wrap this in a `<Suspense />`, but below we use this value to know if we should render the empty state, so unfortunately I need to resolve here. Any ideas?
vercel[bot] created a comment on a pull request on makeswift/vibes
[vc]: #TtXios4CfYbMH/sYm5WRJS774gb57BRpZAkR5nwD5Nw=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJ2aWJlcyIsInJvb3REaXJlY3RvcnkiOiJhcHBzL3dlYiIsImluc3BlY3RvclVybCI6Imh0d...
jorgemoya opened a pull request on makeswift/vibes
feat: add streamable props in Reviews section
- Wraps `<Reviews />` in `Suspense` boundary and internally resolves Promises if passed. - Adds missing `reviewsLabel`.
vercel[bot] created a comment on a pull request on makeswift/vibes
@jorgemoya is attempting to deploy a commit to the **Makeswift** Team on [Vercel](https://vercel.com). A member of the Team first needs to [authorize it](https://vercel.com/git/authorize?team=Make...
migueloller pushed 10 commits to main makeswift/vibes
- fix: use appropriate ESLint parser and shared config 99296cc
- lint: match Catalyst import order 9ada7f4
- chore: remove Prettier sort order plugin 067a626
- chore: run `prettier --write` and `eslint --fix` da7732f
- fix: type mismatch in `getVariableCode` 18b9e7a
- feat: clean up brand CSS vars style tag 6c91468
- ci: add typecheck CI step 2dd6f95
- fix: resolve all ESLint errors 9105a3c
- feat: re-enable linting in CI and builds 21b18bb
- chore: Prettier 3ab6483
migueloller closed a pull request on makeswift/vibes
Match Prettier and ESLint to Catalyst
This PR configures a couple of things with Prettier and ESLint to better match Catalyst. - Removes Prettier import order plugin in favor of ESLint `import/order` rule - Fixed ESLint config by usi...
migueloller pushed 3 commits to miguel/eng-6852-vibes-uses-interface-instead-of-type makeswift/vibes
migueloller pushed 1 commit to miguel/eng-6852-vibes-uses-interface-instead-of-type makeswift/vibes
- chore: Prettier ddf64e3
migueloller pushed 6 commits to miguel/eng-6852-vibes-uses-interface-instead-of-type makeswift/vibes
migueloller pushed 2 commits to miguel/eng-6852-vibes-uses-interface-instead-of-type makeswift/vibes
migueloller pushed 4 commits to miguel/eng-6852-vibes-uses-interface-instead-of-type makeswift/vibes
linear[bot] created a comment on a pull request on makeswift/vibes
<p><a href="https://linear.app/makeswift/issue/ENG-6852/vibes-uses-interface-instead-of-type">ENG-6852 VIBES uses `interface` instead of `type`</a></p>
andrewreifman pushed 3 commits to alan/vib-875-hide-carousel-scrollbar-and-arrows-when-there-is-no makeswift/vibes
andrewreifman pushed 1 commit to main makeswift/vibes
- fix: remove button and button link easing and duration 9032962
andrewreifman closed a pull request on makeswift/vibes
fix: remove button and button link easing and duration
andrewreifman opened a pull request on makeswift/vibes
fix: remove button and button link easing and duration
andrewreifman pushed 1 commit to main makeswift/vibes
- fix: move margins for button in slideshow bd82930