Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
bormilan created a review comment on a pull request on inaka/elvis_core
yes, I just wrote this without thinking. The problem was exactly this even at the beginning of this fix.. 😅
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
Something like this ☝🏻 should work
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
```suggestion ListInitClauses = case is_relevant_behaviour(Root, RuleConfig) of true -> IsInit1Function = fun(Node) -> ...
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
This won't work, @bormilan … `Init1Fun` being `[]` will only cause errors down the line. I'll make a code suggestion that's more likely to work in this case…
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
https://github.com/erlang/otp/issues/8985
bormilan created a review comment on a pull request on inaka/elvis_core
Okay, I will make it! Thank you for the help!
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
Drop a note like this one when you do it… ```erlang case elvis_code:find(IsInit1Function, Root) of [] -> %% A module that implements the behaviour without defining init/1 is valid ...
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
Well… it seems like there is no way to bypass the behaviour check in the Erlang compiler, so… Do not add such a test, but do fix the code to account for `elvis_code:find(…)` returning `[]` here.
bormilan created a review comment on a pull request on inaka/elvis_core
I see, something like this: -compile([{nowarn_unused_function}]).
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
I added the module (granted: I didn't add no test for it) locally and it seems to compile just fine. What error are you seeing?
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
So the compiler compiles all the modules that we use for testing? I was not aware of that. In any case, you can add a `-compile(…).` attribute to the module to avoid warnings. I'll see if I can fin...
bormilan created a review comment on a pull request on inaka/elvis_core
yes, I'm going to add all of them.
bormilan created a review comment on a pull request on inaka/elvis_core
umm, I'm trying but the compilation fails if there are some undefined callback functions.
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
If you add a simple test for each one of them… like the module below… much better. If not, no big deal. ```erlang -module(fail_{BEHAVIOUR}). -behaviour({BEHAVIOUR}). -export([init/1]). ...
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
```suggestion #{behaviours => [gen_server, gen_statem, gen_fsm, supervisor, supervisor_bridge, gen_event]}; ``` Let's add the other ones that I found while grepping for `-callback init` in...
elbrujohalcon created a review on a pull request on inaka/elvis_core
We're almost there, @bormilan … really really close to the final version.
bormilan created a review comment on a pull request on inaka/elvis_core
Ohhh I see. Now it's finally clear, it's nice that I started working on this so I could learn this :D
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
Exactly! All OTP behaviours expect a single argument in `init(…)`. That's what kickstarted this whole thing. `gen_server` docs use a list as _InitArgs_… while in reality it's just a single _InitArg...