Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
bormilan created a review comment on a pull request on inaka/elvis_core
If I have a full understanding, you say this because we don't want to really know what the args of `init/2` are, because `gen_server` needs `init/1` at every case, and we only want to check that if...
bormilan created a comment on a pull request on inaka/elvis_core
> > The only test that is not working now is the one with the `init([])` because its attribute type is `nil`. I don't know how I will solve this, it may need some extra magic. Or is it a bug in `ka...
bormilan created a comment on a pull request on inaka/elvis_core
> precisely Oh! Okay, that's nice, I started to dig into the code of katana, thanks for the clarification.
bormilan created a review comment on a pull request on inaka/elvis_core
Okay, thanks for the feedback!
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
Please add a test for that.
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
This would be true for a function like `init([_], second_argument) -> …` (it has 1 list argument) and that function does **not** break the rule.
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
I still think it would be better to filter out more functions here… ```suggestion IsFunction = fun(Node) -> ktn_code:type(Node) == function andalso ktn_code:attr(name, Node) == in...
elbrujohalcon created a comment on a pull request on inaka/elvis_core
> The only test that is not working now is the one with the `init([])` because its attribute type is `nil`. I don't know how I will solve this, it may need some extra magic. Or is it a bug in `kata...
bormilan created a comment on a pull request on inaka/elvis_core
The only test that is not working now is the one with the `init([])` because its attribute type is `nil`. I don't know how I will solve this, it may need some extra magic. Or is it a bug in `katana...
bormilan created a review comment on a pull request on inaka/elvis_core
But I think I can make something like this in my new code too.
bormilan created a review comment on a pull request on inaka/elvis_core
Oh, I was so engrossed in work that I had not checked your comments and I reworked all this... (And I didn't get notifications, which is weird)
bormilan created a comment on a pull request on inaka/elvis_core
> > Yes! I like making more and more tests to feel that my code is 100% good. > > HA! I just saw that you were matching against a single `[BehaviourNode]` in your code… and I wondered "what woul...
elbrujohalcon created a comment on a pull request on inaka/elvis_core
> Yes! I like making more and more tests to feel that my code is 100% good. HA! I just saw that you were matching against a single `[BehaviourNode]` in your code… and I wondered "what would happ...
bormilan created a comment on a pull request on inaka/elvis_core
> One more test (or maybe two, if you want a fail and a pass), @bormilan: > > * A module that implements `gen_server` AND another behaviour… > > ```erlang > -module(fail…). > > -behaviour...
elbrujohalcon created a review on a pull request on inaka/elvis_core
One more test (or maybe two, if you want a fail and a pass), @bormilan: * A module that implements `gen_server` AND another behaviour… ```erlang -module(fail…). -behaviour(gen_server). -...
elbrujohalcon created a review on a pull request on inaka/elvis_core
One more test (or maybe two, if you want a fail and a pass), @bormilan: * A module that implements `gen_server` AND another behaviour… ```erlang -module(fail…). -behaviour(gen_server). -...
elbrujohalcon created a review on a pull request on inaka/elvis_core
One more test (or maybe, two), @bormilan: * A module that implements `gen_server` AND another behaviour… ```erlang -module(fail…). -behaviour(gen_server). -behaviour(another_behaviour). ...
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
You can (probably… I had not tested it) simplify this multi-loop algorithm on a single list comprehension… ```suggestion case is_rule_behaviour(Root, RuleConfig) of true -> ...
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
Renaming suggestion: `is_relevant_behaviour` or `is_important_behaviour` or `is_known_behaviour`. `is_rule_behaviour`, to me, sounds like if it's looking for `-behaviour(rule).`
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
If you follow my suggestion above, you can simplify this… ```suggestion ResultFun = fun(Location) -> Info = [Location], Msg = ?NO_INIT_LISTS_MSG, ...