Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
```suggestion [Location || {init, Location, [_]} <- FunListAttributeInfos]; ``` You can use list comprehensions to filter… and, since you only need the location later, you can ju...
bormilan created a review comment on a pull request on inaka/elvis_core
Yes, I commented it out because I just experienced a weird bug that said it's not used. (But I clearly used it) I will investigate it, this is a temporary solution.
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
https://github.com/AdRoll/rebar3_hank/issues/221
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
Actually… this is a great idea for a Hank rule: _Unused features_ 🤔
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
```suggestion gen_server:start_link(?MODULE, 1, []). ``` Subtle and pointless, but just for consistency (i.e., to match what `init/1` expects).
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
```suggestion gen_server:start_link(?MODULE, {1, 2}, []). ``` Subtle and pointless, but just for consistency (i.e., to match what `init/1` expects).
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
```suggestion gen_server:start_link(?MODULE, #{a => map}, []). ``` Subtle and pointless, but just for consistency (i.e., to match what `init/1` expects).
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
```suggestion lists:member(ktn_code:attr(value, BehaviourNode), Behaviors) ```
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
I'm gonna guess we'll need this macro before merging the PR, right?
elbrujohalcon created a review comment on a pull request on inaka/elvis_core
I don't think you need this anymore, do you?
elbrujohalcon created a review on a pull request on inaka/elvis_core
A few small suggestions, but overall great progress @bormilan 👍🏻
elbrujohalcon created a review on a pull request on inaka/elvis_core
A few small suggestions, but overall great progress @bormilan 👍🏻
elbrujohalcon created a comment on a pull request on inaka/elvis_core
@bormilan do you mind merging `main` into your branch, please?
elbrujohalcon closed an issue on inaka/elvis_core
max_function_length counts multiple function clauses as a single function
## Bug Description **Note**: might not be a bug. `max_function_length` complains if a function definition spans over a given number of lines (by default: 30)... ... **but** it's also takin...
elbrujohalcon pushed 1 commit to main inaka/elvis_core
- New `elvis_style` rule: `max_function_clause_length` (#365) add max_function_clause_length rule 6be281f
elbrujohalcon closed a pull request on inaka/elvis_core
New `elvis_style` rule: `max_function_clause_length`
# Description I added a new rule called `max_function_clause_length`. The old rule `max_function_length` stays the same, it checks the length of an entire function, but now we can check the siz...
elbrujohalcon created a comment on a pull request on inaka/elvis_core
Thanks, @bormilan !!! Amazing work.
bormilan created a comment on a pull request on inaka/elvis_core
I still have some work to do, but it keeps getting better.