Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
geissonator closed a pull request on ibm-openbmc/bmcweb
Accounts/service ACF properties added
For the 1120 rebase, merge all ACF and Service user commits into one. This will ensure future cherry-picks of this downstream function are easier to bring in. Having it spread across multiple commi...
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
Weird, that test isn't altered with this commit, right? I would think it would fail upstream also with the constexpr. Oh well, guess best to just leave as-is.
geissonator created a review comment on a pull request on ibm-openbmc/bmcweb
I don't know the details of this test, but it seems to require static const? I get this error with constexpr: ``` from ../redfish-core/include/privileges.hpp:6, ...
geissonator created a review comment on a pull request on ibm-openbmc/bmcweb
Squashed it in to this commit
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
The upstream Description has roleId + " User Role". Should this case still have that?
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
Seems like if we leave this at line 2230 it would be one less potential future rebase merge conflict to deal with. I don't see userSelf being used before that line.
jeaaustx created a review comment on a pull request on ibm-openbmc/bmcweb
Can't this still be constexpr?
gtmills created a review comment on a pull request on ibm-openbmc/bmcweb
https://github.com/openbmc/bmcweb/blob/cc67d0a0fed101c930b334a583d9ca9b222ceb77/DEVELOPING.md?plain=1#L227
