Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jsync-swirlds created a comment on a pull request on hashgraph/hedera-block-node
> @jsync-swirlds thanks for the reviews. > > Keep in mind that when I was doing these changes (as well as the ones in the simulator in the other PR), my aim was to only kind of 'redirect' all cu...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
I would recommend just removing these permissions from the remover. If we cannot delete a file, we also cannot change permissions (at least in any POSIX compliant system).
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
As we discussed, it comes down to file and folder permissions and the need to keep them separate. Also, it seems the commons method should have just been for creating folders, not both files and f...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
1. Yes, both reader and writer are not expected to be used in production, but we mustn't design them as test code, because any operator _might_ choose to use them as the production storage for what...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
It should be restored and the constants _used_ in the appropriate calls. The reason you don't see usage is that you removed that usage. In reality we should be using these constants as parameters...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
`File` is an older API that should be replaced by `Path` in nearly all cases. In most cases the construction of a File is either in unit tests, or a leftover from older API assumptions. Note, t...
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
Rather than spin up new Threads individually (expensive). Consider using `private ExecutorService executorService = Executors.newFixedThreadPool(8)` and managing simulator instances from that API w...
mattp-swirldslabs created a review on a pull request on hashgraph/hedera-block-node
I like the new structural changes. Try out the thread management changes commented on and see if you can utilize that ExecutorService API.
mattp-swirldslabs created a review on a pull request on hashgraph/hedera-block-node
I like the new structural changes. Try out the thread management changes commented on and see if you can utilize that ExecutorService API.
github-actions[bot] pushed 1 commit to gh-pages hashgraph/hedera-block-node
- Publish hedera-block-node-0.2.0-SNAPSHOT.tgz 50ef178
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/312?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
jsync-swirlds pushed 1 commit to main hashgraph/hedera-block-node
- chore: change spotless base format to Palantir plugin (#312) Signed-off-by: Joseph Sinclair <joseph.sinclair@swirlds... d829247
jsync-swirlds closed a pull request on hashgraph/hedera-block-node
chore: change spotless base format to Palantir plugin
* Modified the gradle setup * Ran a full spotlessApply; no change
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/312?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
jsync-swirlds opened a pull request on hashgraph/hedera-block-node
Change spotless base format to Palantir plugin
* Modified the gradle setup * Ran a full spotlessApply; no change
jsync-swirlds created a branch on hashgraph/hedera-block-node
switch-spotless-to-palantir - New Block Node services
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
The point of the overload is to enable a class like this to accept defaults without having to manage that default value. It's fine to remove the class attribute, but it also makes sense to _allo...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
I generally agree on `var`, except when it makes a major improvement in readability, as here.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
IDE defaults are a pain sometimes...