Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/307?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/307?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/307?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
I agree that the file should generally be retained, I removed it since all the usages it had are no longer used, and we would have had a class with either no fields (if I deleted the unused, in our...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
✅ I reversed the formatting on the docs everywhere. It was indeed a problem with the IDE, I do use only spotlessApply, but looks like the IDE formatting also went through and I thought that was spo...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
✅ Personally I would never use `var`, but since that is the accepted norm and if it saves us the line break, I take a note. This is reversed now. And as for the reformatting, I do only use spotless...
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/271?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
✅ I reversed the formatting on the docs everywhere. It was indeed a problem with the IDE, I do use only spotlessApply, but looks like the IDE formatting also went through and I thought that was spo...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
✅ I reversed the formatting on the docs everywhere.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
✅ I reversed the formatting on the docs everywhere.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
✅ I reversed the formatting on the docs everywhere.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
✅ I improved this, extracted the comparator to be more readable.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
✅ I reversed the formatting on the docs everywhere.
AlfredoG87 created a review on a pull request on hashgraph/hedera-block-node
LG, just 1 question/nit.
ata-nas pushed 1 commit to 253-refactor-use-commons-module-in-simulator hashgraph/hedera-block-node
- addressing some comments, mostly on styling and javadocs Signed-off-by: Atanas Atanasov <[email protected]> ee058f2
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
I did this for convenience, since the only place I use that, I need to call `blockFile.getPath()`, and thought that it would be good to simply have this convenience where I do not need to call `get...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
@jsync-swirlds I do share your concern for breaking the existing logic if we change the implementation, I did mention that in my comment, I do not believe that if we change to an `if-else` we will ...