Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
✅ I reversed the formatting on the docs everywhere.
AlfredoG87 created a review on a pull request on hashgraph/hedera-block-node
LG, just 1 question/nit.
ata-nas pushed 1 commit to 253-refactor-use-commons-module-in-simulator hashgraph/hedera-block-node
- addressing some comments, mostly on styling and javadocs Signed-off-by: Atanas Atanasov <[email protected]> ee058f2
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
I did this for convenience, since the only place I use that, I need to call `blockFile.getPath()`, and thought that it would be good to simply have this convenience where I do not need to call `get...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
@jsync-swirlds I do share your concern for breaking the existing logic if we change the implementation, I did mention that in my comment, I do not believe that if we change to an `if-else` we will ...
ata-nas created a comment on a pull request on hashgraph/hedera-block-node
@jsync-swirlds thanks for the reviews. Keep in mind that when I was doing the changes, my aim was to only `redirect` all current usages of the utilities and constants to the new `common` module ...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Same as above comment
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Also, my comment is the same as my above response, considered only for the tests isolated.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Agreed about that. Based on comments above and on what we shall agree on, if to remove or not the `filePerms` field in the super, this would either become `null` and the actual reader will use the ...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Good question, I am not sure as well. The file perms are used in a method inside the remover `remove(long)`. Based on the comments inside and the single usage it has currently, I believe the method...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Please see my response for this in the above comments, for the `BlockAsDirWriterBuilder` and `BlockAsDirWriterBuilder`, it applies here as well.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Please see my response for this in the above comments, for the `BlockAsDirWriterBuilder` and `BlockAsDirWriterBuilder`, it applies here as well.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Agreed about that, but since this class is not a production class, do you envision that we will ever need anything else than the defaults, meaning to use the overloaded method? If not, can we then ...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Agreed about that.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
I agree for the constants of the file permissions that should be private, it does make sense for them to be only part of the `FileUtilities` _internally_. I made them public, because I only want...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
I seem to be confused about this. Technically we will always either create a directory or a file. We will never need both `filePermissions` and `folderPermissions`, we technically need only one ...