Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
white_check_mark: Done.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
white_check_mark: Done.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
white_check_mark: Done.
ata-nas pushed 1 commit to 252-refactor-use-commons-module-in-server hashgraph/hedera-block-node
- addressing some comments, mostly on styling and javadocs Signed-off-by: Atanas Atanasov <[email protected]> 4d4f691
jasperpotts pushed 17 commits to 231-add-block-stream-tools hashgraph/hedera-block-node
- ci: GitHub Actions `Release automation` WorkFlow (#82) Signed-off-by: Alfredo Gutierrez <[email protected]> 90e556a
- feat: Simulator: BlockStreamManager impl for very large DataSets (#225) Signed-off-by: Alfredo Gutierrez <alfredo@sw... a3a97cc
- ci: Update release-automation.yaml to enable completion (#236) Signed-off-by: Roger Barker <roger.barker@swirldslabs... d55321f
- fix: update-env.sh now injects JAVA_OPTS params (#245) Signed-off-by: Matt Peterson <[email protected]> dca9566
- feat: Add simulator as dependency in Suites (#242) Signed-off-by: georgi-l95 <[email protected]> 3a565f3
- chore(release): Bump versions for v0.2.0-SNAPSHOT (#246) Signed-off-by: Swirlds Automation <swirlds-eng-automation@s... e89eef4
- feat: cAdvisor Docker System Metrics and Dashboard for Dev Docker Stack (#258) Signed-off-by: Alfredo Gutierrez <alf... c2a360a
- refactor: introduce commons module (#251) Signed-off-by: Atanas Atanasov <[email protected]> Signed-off-by: ... 1e0288c
- feat: added MILLIS_PER_BLOCK Streaming mode to the simulator (#248) Signed-off-by: Alfredo Gutierrez <alfredo@swirld... 611e91b
- refactor: adjust configuration management and smoke test setup to support production config by default (#232) Signed... c0ce015
- docs: Add a protocol document for `publishBlockStream` (#267) Signed-off-by: Joseph Sinclair <joseph.sinclair@swirld... d4d8a6e
- ci: Change "contents" persmission and add hardened runner step (#283) Signed-off-by: Mihail Mihov <mihail.mihov@lime... 560404c
- test: introduce tests in common module (#274) Signed-off-by: Atanas Atanasov <[email protected]> f5f1ed2
- refactor: Stream of repeated block items instead of block items (#269) Signed-off-by: Alfredo Gutierrez <alfredo@swi... 4fb471c
- feat: Improvements ChunkUtils (#289) Signed-off-by: Alfredo Gutierrez <[email protected]> 8d10540
- ci: Updating workflow actions to step-security maintained version. (#304) Signed-off-by: Vasil Boyadzhiev <vasil.boy... 446103e
- Merge branch 'main' into 231-add-block-stream-tools Signed-off-by: Jasper Potts <[email protected]... 5478fc2
jasperpotts pushed 5 commits to 231-add-block-stream-tools hashgraph/hedera-block-node
- ci: GitHub Actions `Release automation` WorkFlow (#82) Signed-off-by: Alfredo Gutierrez <[email protected]> Si... 66462da
- Added new block stream tool Signed-off-by: jasperpotts <[email protected]> 0fca2dd
- Added more info to BlockInfo. Made them parallel :-) . Added option to filter by file size. Signed-off-by: jasperpot... 889b63d
- Added more info to BlockInfo. Made them parallel :-) . Added option to filter by file size. Signed-off-by: jasperpot... 71af704
- Added readme and resolved PR issues Signed-off-by: jasperpotts <[email protected]> 3b0e180
jasperpotts pushed 16 commits to 231-add-block-stream-tools hashgraph/hedera-block-node
- feat: Simulator: BlockStreamManager impl for very large DataSets (#225) Signed-off-by: Alfredo Gutierrez <alfredo@sw... a3a97cc
- ci: Update release-automation.yaml to enable completion (#236) Signed-off-by: Roger Barker <roger.barker@swirldslabs... d55321f
- fix: update-env.sh now injects JAVA_OPTS params (#245) Signed-off-by: Matt Peterson <[email protected]> dca9566
- feat: Add simulator as dependency in Suites (#242) Signed-off-by: georgi-l95 <[email protected]> 3a565f3
- chore(release): Bump versions for v0.2.0-SNAPSHOT (#246) Signed-off-by: Swirlds Automation <swirlds-eng-automation@s... e89eef4
- feat: cAdvisor Docker System Metrics and Dashboard for Dev Docker Stack (#258) Signed-off-by: Alfredo Gutierrez <alf... c2a360a
- refactor: introduce commons module (#251) Signed-off-by: Atanas Atanasov <[email protected]> Signed-off-by: ... 1e0288c
- feat: added MILLIS_PER_BLOCK Streaming mode to the simulator (#248) Signed-off-by: Alfredo Gutierrez <alfredo@swirld... 611e91b
- refactor: adjust configuration management and smoke test setup to support production config by default (#232) Signed... c0ce015
- docs: Add a protocol document for `publishBlockStream` (#267) Signed-off-by: Joseph Sinclair <joseph.sinclair@swirld... d4d8a6e
- ci: Change "contents" persmission and add hardened runner step (#283) Signed-off-by: Mihail Mihov <mihail.mihov@lime... 560404c
- test: introduce tests in common module (#274) Signed-off-by: Atanas Atanasov <[email protected]> f5f1ed2
- refactor: Stream of repeated block items instead of block items (#269) Signed-off-by: Alfredo Gutierrez <alfredo@swi... 4fb471c
- feat: Improvements ChunkUtils (#289) Signed-off-by: Alfredo Gutierrez <[email protected]> 8d10540
- ci: Updating workflow actions to step-security maintained version. (#304) Signed-off-by: Vasil Boyadzhiev <vasil.boy... 446103e
- Merge branch 'main' into 231-add-block-stream-tools 8a6fc31
mattp-swirldslabs created a review on a pull request on hashgraph/hedera-block-node
Do you mind adding a README.md with some of the common usages?
jasperpotts pushed 1 commit to 231-add-block-stream-tools hashgraph/hedera-block-node
- Added readme and resolved PR issues 5663227
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
Same comments as above.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
Either accept _private_ defaults, or set explicit values in the test. Having a test explicitly set a value it doesn't control is asking for a brittle test failure.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
Why are we setting permissions for removing folders? That seems broken and incorrect.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
As noted elsewhere, it's never correct to copy a constant like this into a class attribute. Either the caller supplies the value, or it's null.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
Just remove this paragraph, it is describing internal details of a different library. Also, defaults are never acceptable for production in this case; defaults are for testing and development; con...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
Just use the override with defaults for this class; it's not a production class. In the production classes we'll _always_ set file and folder permissions, which should _not_ have a default outside...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
We shouldn't be digging into commons for constants, any constants we need belong in this module. That said, there should not be defaults for file or folder permissions. Those need to be in config...
jsync-swirlds created a review on a pull request on hashgraph/hedera-block-node
That's the rest reviewed. Let's chat about this code, as there are obviously some gaps in terms of understanding why some things are written the way they were.
jsync-swirlds created a review on a pull request on hashgraph/hedera-block-node
That's the rest reviewed. Let's chat about this code, as there are obviously some gaps in terms of understanding why some things are written the way they were.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
Just remove the paragraph, and leave the default permissions as an internal detail of the commons module.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
All changes to this file are incorrect. You are re-introducing a severe design flaw by merging the permissions types, and the constants are not supposed to be public _for good reason_.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
This is wrong. Files and folders MUST NOT have the same permissions.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
This is unnecessary.