Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AlfredoG87 closed an issue on hashgraph/hedera-block-node
Change all Helidon-related elements to support `List<BlockItem>`.
As a Consensus Node I Want to stream Block Items in repeated batches So That I can improve the channel efficiency and reduce streaming overhead ### Technical Notes Currently we are using prot...AlfredoG87 closed a pull request on hashgraph/hedera-block-node
refactor: Stream of repeated block items instead of block items
**Description**: This PR changes the version of `hedera-protobuf` and refactors all the project due to 2 fundamental changes to the API spec. 1. Service was changed from 1 single service call...jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
Don't forget to reset this before merging.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
Just a note, the latest PR removes this message and replaces it with a more generic `BlockItemSet`, because it turned out we needed a `oneof` in the publish API too.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
We should plan to remove this soonish. It was supposed to be temporary, and we are better off using the "real" protos, even for tests.
mattp-swirldslabs created a review on a pull request on hashgraph/hedera-block-node
Looks good
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
I added this item: " Review Optional return value from the Writer so downstream code can generate the correct response"
ata-nas created a review on a pull request on hashgraph/hedera-block-node
Looks good to me, all comments I had on everything I managed to find is now resolved. Please see others as well! 👍
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/269?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
@jsync-swirlds +1 from me for the discussion & resolved by @AlfredoG87
AlfredoG87 pushed 1 commit to repeated-block-items-refactor hashgraph/hedera-block-node
- replaced with single import Signed-off-by: Alfredo Gutierrez <[email protected]> 925b9f7
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
✅ Done!
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
I've opened a [discussion item](https://github.com/hashgraph/hedera-block-node/discussions/287) to discuss the proposed process and format.
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/269?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
✅ Done!
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
✅ Done!
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
✅ Removed!
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
✅ Done!
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
✅ Done!
AlfredoG87 pushed 16 commits to repeated-block-items-refactor hashgraph/hedera-block-node
- ci: Change "contents" persmission and add hardened runner step (#283) Signed-off-by: Mihail Mihov <mihail.mihov@lime... 560404c
- test: introduce tests in common module (#274) Signed-off-by: Atanas Atanasov <[email protected]> f5f1ed2
- temporary commit to use protobuf from temporal branch block-repeated-fix-tss-message, hopefully by the time this read... 81c2147
- simple changes to allow the simulator to stream List<BlockItems> instead of individual block items. Pending to add a... 3b2be50
- Changes to Helidon and Services Signed-off-by: Alfredo Gutierrez <[email protected]> da2cc06
- Fixing Unit Tests Signed-off-by: Alfredo Gutierrez <[email protected]> 27a259a
- Refactor BlockStreamService to extract BlockAccessService Signed-off-by: Alfredo Gutierrez <[email protected]> 544dd6b
- Enable BlockAccessService as part of the GRPC Routes in the BlockNodeApp, fixed scripts for smoke-test and created an... d6a80bf
- Added missing UT to complete coverage Signed-off-by: Alfredo Gutierrez <[email protected]> 2d77799
- - Refactored BlockStreamConfig and extracted BlockGeneratorConfig Properties to its own record class. - Added generat... d59bcaf
- - More fixes to the simulator and it's tests. - Updated the README.md and app.properties example file. - Simplify som... bf75e9c
- added missing UT Signed-off-by: Alfredo Gutierrez <[email protected]> 7086c45
- Addressing PR Review comments, suggestions and improvements. Signed-off-by: Alfredo Gutierrez <[email protected]> a0dd2c4
- restoring app.properties to defaults Signed-off-by: Alfredo Gutierrez <[email protected]> ea98ce3
- Addressing more feedback from PR Reviews Signed-off-by: Alfredo Gutierrez <[email protected]> 0092362
- addressing warnings and adding unit test for Chunkify Util Signed-off-by: Alfredo Gutierrez <[email protected]> 5369431