Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
github-actions[bot] pushed 1 commit to gh-pages hashgraph/hedera-block-node
- Publish hedera-block-node-0.2.0-SNAPSHOT.tgz 2143ac0
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
https://github.com/hashgraph/hedera-block-node/issues/285
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
https://github.com/hashgraph/hedera-block-node/issues/286
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Can you please add some tests for this as well? https://github.com/hashgraph/hedera-block-node/pull/274 is now available and will be even easier! :)
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Awesome, sounds good.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Noted, thanks for the clarification! :)
AlfredoG87 opened an issue on hashgraph/hedera-block-node
Add Error Handling to Simulator
### Problem Currently when the simulator is running and the block-node server returns an `onError` message, the simulator just logs the message and continues as if nothing has happenend. ### Solu...
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/274?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas pushed 1 commit to main hashgraph/hedera-block-node
- test: introduce tests in common module (#274) Signed-off-by: Atanas Atanasov <[email protected]> f5f1ed2
ata-nas closed an issue on hashgraph/hedera-block-node
test: introduce tests in common module
## Story **AS A** Block Node Developer **I WANT** to have unit tests for `:common` **SO THAT** we have unit tests for `:common`
ata-nas closed a pull request on hashgraph/hedera-block-node
test: introduce tests in common module
**Description**: - add tests in the `:common` module **Related issue(s)**: Fixes #273 **Notes for reviewer**: - am I missing some tests or edge cases? **Checklist** - [x] add unit test...
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
No, this increment refers only to a whole block. 👍
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
I prefer to return an empty collection, I think it makes it more generic to any use case. Maybe just add to the javadoc the expected behaviour to keep things simple.
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
Is my understanding that the `.forEach` is executed in parallel (could be wrong) , also, is less performant (this is true). But ultimately, a regular For gives you more flexibility overall and a cl...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
This is blocks, not block items, so it only ever increments by one at a time. We _should not_ ever have multiple blocks in one set of items, nor parts of two different blocks in the same set.
