Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
Is my understanding that the `.forEach` is executed in parallel (could be wrong) , also, is less performant (this is true). But ultimately, a regular For gives you more flexibility overall and a cl...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
This is blocks, not block items, so it only ever increments by one at a time. We _should not_ ever have multiple blocks in one set of items, nor parts of two different blocks in the same set.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
@AlfredoG87 noted, I keep this conversation open as a reminder, feel free to resolve it after you open an issue, or if you think that this todo is enough for now. Also @jsync-swirlds has a quite go...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Noted, glad you like the idea! For me is resolved, either with the advanced for or the `forEach`, up to you. I wonder however what concerns do you have about performance and concurrency by usin...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
@jsync-swirlds agreed for the .env file, it is dangerous indeed, when I was talking about `env variables` I did indeed mean environment variables and not the .env file, but your point is quite impo...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
We do not need cleanup in the `@AfterEach` method, by default junit will attempt to recursively delete the `@TempDir` and if it does not succeed it should throw an exception and the test should fai...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
maybe this was added here by mistake?
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
We do not need cleanup in the `@AfterEach` method, by default junit will attempt to recursively delete the `@TempDir` and if it does not succeed it should throw an exception and the test should fai...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Consider to add `@NonNull` to the `collection` parameter
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Should we throw here or return an empty collection? What should be the general behavior?
ata-nas created a review on a pull request on hashgraph/hedera-block-node
Looking better! A couple comments on latest changes only reviewed.
ata-nas created a review on a pull request on hashgraph/hedera-block-node
Looking better! A couple comments on latest changes only reviewed.
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/271?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas pushed 3 commits to 253-refactor-use-commons-module-in-simulator hashgraph/hedera-block-node
- refactoring Constants and Utils classes from simulator Signed-off-by: Atanas Atanasov <[email protected]> 6f4a1e5
- use app properties from StringsConstants in simulator Signed-off-by: Atanas Atanasov <[email protected]> 44441b8
- minor refactoring and additional file reading method overload for easier usage and spotlessApply Signed-off-by: Atan... a44ffcc
ata-nas pushed 4 commits to 252-refactor-use-commons-module-in-server hashgraph/hedera-block-node
- refactoring Constants Signed-off-by: Atanas Atanasov <[email protected]> ac0d6d7
- additional refactoring to use FileUtilities Signed-off-by: Atanas Atanasov <[email protected]> 6ec5c6e
- fixing a failing unit test to support the new logic Signed-off-by: Atanas Atanasov <[email protected]> fb25018
- regain test coverage Signed-off-by: Atanas Atanasov <[email protected]> 40350e5
ata-nas pushed 7 commits to 273-test-introduce-tests-in-common-module hashgraph/hedera-block-node
- add some tests for the StringUtilities Signed-off-by: Atanas Atanasov <[email protected]> 2badfd4
- adding test dependencies Signed-off-by: Atanas Atanasov <[email protected]> 23f600c
- adding some gzip tests Signed-off-by: Atanas Atanasov <[email protected]> ce500ba
- adding some path creation tests Signed-off-by: Atanas Atanasov <[email protected]> 26b7a7c
- adding more file reading tests Signed-off-by: Atanas Atanasov <[email protected]> 0b79d0d
- small refactoring Signed-off-by: Atanas Atanasov <[email protected]> 675bc3e
- spotlessApply Signed-off-by: Atanas Atanasov <[email protected]> af0e133
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/271?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/272?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...