Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
should we add it to an epic? Maybe the Persist Story Epic https://github.com/hashgraph/hedera-block-node/issues/194
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
There is no guarantee we won't receive an empty/null value in the stream. We'll need to handle it properly.
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
We _might_ choose to count message tags in the byte array and record that. We'll need to be able to split the byte array into separate items without parsing anyway, for verification, so that code ...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
We may want to consider a process for these. Something like this might work: ``` A "TODO" comment is permitted, but it must include a ticket ID. We prefer the following format. `@todo(###) des...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
Please be careful with `.env`. In my opinion we should not even use such files, due to the very high incidence of secrets being exposed with `.env` files. Environment variables (set via appropria...
jsync-swirlds created a review comment on a pull request on hashgraph/hedera-block-node
I generally agree, but in rare instances it fixes the thoroughly excessive wrapping caused by the current spotless configuration. When it saves multiple line wraps, and is not ambiguous, I would a...
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/269?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
Nana-EC created a comment on an issue on hashgraph/hedera-block-node
@AlfredoG87 and @georgi-l95 we should pull this out of the current EPIC as it's not a Phase 1 goal. Unclear if it need to be under a new EPIC or is fine as specified
jsync-swirlds created a comment on an issue on hashgraph/hedera-block-node
Some confusion is evident in this description. 1. Blocks contain rounds, not the other way around 1. We will have roughly 1 block per second, which may contain arbitrary numbers of rounds (and that...
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
I think we should never encounter that null, that would mean an empty batch.
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
I like your approach, but I rather not use `.forEach` for concurrency and performance concerns. other than that, happy to implement this improvement, and YES! this is a bug waiting to happen, will...
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
I think we should be able to support them, is this something that can be done as part of a separate PR? as a follow-up? I don't think the refactor should have an even bigger scope for now. My pr...
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
Good find, this is indeed something that needs more time to determine the cause, I will change it to a TODO, so we don't miss it on a followup.