Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
Good catch @ata-nas. These test parameters are intentionally very narrow. If you have to loosen them, I think it indicates there might be a bug. Let's collaborate to make sure the code is correct.
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
I worked!! thanks!! :) I guess I missed that api due to expecting it as a overload 😅
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
This compiles: ` metricsService.get(LiveBlockItems).add(blockItems.size());` but I haven't tested it.
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
Not now, these packages are necessary to disambiguate the protoc version from PBJ types
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
This is another example of PlatformSDK metrics API feature limitations, any other prometheus client would have a `increment(number)` overload that increments more than `1` at the time such counter....
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
Remove commented code?
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
Remove commented code?
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
Remove commented code?
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
Remove commented code?
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
Many of these member variable are not used and can be removed
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
I think you can use this rather than a loop: ``` metricsService.get(LiveBlockItems).add(blockItems.size()) ```
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
We will have to figure out what Optional to return here so the downstream response can be generated. This is probably ok for now.
mattp-swirldslabs created a review on a pull request on hashgraph/hedera-block-node
Nice work. I added some comments
mattp-swirldslabs created a review on a pull request on hashgraph/hedera-block-node
Nice work. I added some comments
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
I have a concern here with the way this is being batched, hope I am wrong. This int/int division should result in a whole int that would be the closest to the next int (if result is 2.3 then 2 will...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
For the readme and configs in genera, do we need to support configuration with env variables? If yes, then all the key/value pairs need to be mapped inside `com.hedera.block.server.config.ServerMap...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Is the comment on line 154 a `todo` or `fixme`?
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Commented out code, remove maybe?
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Commented out code, remove maybe?