Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
You might add a comment to the storage epic @AlfredoG87 is doing. It should be addressed in a different PR
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
You can add the `@NonNull` annotation to the top of this method.
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
I think you can also test these 3: ``` consumer.timeoutThresholdMillis service.delayMillis persistence.storage.rootPath ```
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
You can use static imports for `Assertions` here ^^
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
You can remove this `UnsupportedOperationException` ^^
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
We should probably add an entries for the other config properties like: ``` consumer.timeoutThresholdMillis service.delayMillis persistence.storage.rootPath ```
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
I think you can remove lines 35 and 36 and add a line to cat the actual values of `.env`
mattp-swirldslabs created a review comment on a pull request on hashgraph/hedera-block-node
Can we set `is_debug` and `is_smoke_test` to boolean values rather than strings?
mattp-swirldslabs created a review on a pull request on hashgraph/hedera-block-node
I added a few comments
mattp-swirldslabs created a review on a pull request on hashgraph/hedera-block-node
I added a few comments
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Noting to some potential dangers here, if the GZ file is too large, it could be an issue!
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/251?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Please resolve `TODO`
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
this file will be deleted
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
this file will be deleted
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
addressed in previous review