Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ata-nas pushed 1 commit to 233-refactor-introduce-commons-module hashgraph/hedera-block-node
- address pr comments based on new agreements Signed-off-by: Atanas Atanasov <[email protected]> 0ec1107
AlfredoG87 created a comment on an issue on hashgraph/hedera-block-node
Results of benchmarking and research: https://www.notion.so/swirldslabs/On-Disk-Block-Archive-Format-11c7c9ab259180319698cd5dad76a75f?pvs=4
AlfredoG87 created a comment on an issue on hashgraph/hedera-block-node
Being worked on this PR: https://github.com/hashgraph/hedera-protobufs/pull/421
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
You mean unit tests for the whole commit in general? If so, I was thinking to do it in the next commits that are related to this based on the epic #254 since the logic here is not used yet. My goal...
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/251?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
how are we going to UT this? We are missing tests on this PR.
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
I think they should be indeed be closed.
AlfredoG87 created a review on a pull request on hashgraph/hedera-block-node
Agreed with comments, thanks for addressing the nits. What about UTs for this codebase?
AlfredoG87 created a review on a pull request on hashgraph/hedera-block-node
Agreed with comments, thanks for addressing the nits. What about UTs for this codebase?
mattp-swirldslabs created a comment on an issue on hashgraph/hedera-block-node
Tracking exploratory data here: https://www.notion.so/swirldslabs/Block-Node-Network-Stack-Troubleshooting-11c7c9ab2591800ca277ed42ecad2b54?pvs=4
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/251?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
addressed in 51da6a1d654c0919796b6dbdd1691fa239c5e3f0 can you please verify?
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
addressed in 51da6a1d654c0919796b6dbdd1691fa239c5e3f0 can you verify that it is correct and is what is needed for the whole file in general? Thanks!
ata-nas pushed 1 commit to 233-refactor-introduce-commons-module hashgraph/hedera-block-node
- address more comments Signed-off-by: Atanas Atanasov <[email protected]> 51da6a1
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/251?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
`@NonNull` removed, what about the javadoc on these literals? Do we really need comments on these literals?
ata-nas pushed 1 commit to 233-refactor-introduce-commons-module hashgraph/hedera-block-node
- address some comments Signed-off-by: Atanas Atanasov <[email protected]> 6bbefe3
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
@AlfredoG87 do you have an opinion on this?