Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
I think they should be indeed be closed.
AlfredoG87 created a review on a pull request on hashgraph/hedera-block-node
Agreed with comments, thanks for addressing the nits. What about UTs for this codebase?
AlfredoG87 created a review on a pull request on hashgraph/hedera-block-node
Agreed with comments, thanks for addressing the nits. What about UTs for this codebase?
mattp-swirldslabs created a comment on an issue on hashgraph/hedera-block-node
Tracking exploratory data here: https://www.notion.so/swirldslabs/Block-Node-Network-Stack-Troubleshooting-11c7c9ab2591800ca277ed42ecad2b54?pvs=4
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/251?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
addressed in 51da6a1d654c0919796b6dbdd1691fa239c5e3f0 can you please verify?
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
addressed in 51da6a1d654c0919796b6dbdd1691fa239c5e3f0 can you verify that it is correct and is what is needed for the whole file in general? Thanks!
ata-nas pushed 1 commit to 233-refactor-introduce-commons-module hashgraph/hedera-block-node
- address more comments Signed-off-by: Atanas Atanasov <[email protected]> 51da6a1
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/251?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
`@NonNull` removed, what about the javadoc on these literals? Do we really need comments on these literals?
ata-nas pushed 1 commit to 233-refactor-introduce-commons-module hashgraph/hedera-block-node
- address some comments Signed-off-by: Atanas Atanasov <[email protected]> 6bbefe3
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
@AlfredoG87 do you have an opinion on this?
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Again was in the original code, I agree to remove it.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
As a best practice, an error must be thrown, because we could without problem create an instance of this class using reflection, no matter that the constructor is private. When we have an exception...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
the `@NonNull` was present in the code that these were coming from, I also was wondering why it existed, thanks for pointing out, will be removed. For the javadoc, do we really need it? Do we need...