Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
This is an example generic error message here, I think there are some error messages we would see across modules, as this is an example, I am sure this would be used in a place where we will have a...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
could agree that there is not much added value for the class `String`
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/258?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/258?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
could be simpler to do ```suggestion private StringConstants() { } ``` with a comment that this is a utility class, so that constructor is unreachable, no instances are supported. I thi...
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
Again, why `@NonNull` I think we should only use this decorator on parameters.
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
Could we add a JavaDoc for each one of these aswell? Do we need to decorate them with @NonNull?
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
also remove the '@link String` and improve the doc.
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
Should Error messages be shared across projects? why?
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
we could remove the "@link String` since I don't think it adds that much value.
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
seems redundant to set `application` plugin when is already part of the "com.hedera.block.common" plugin. Also, see prior comment between `application` and `java-library`
AlfredoG87 created a review comment on a pull request on hashgraph/hedera-block-node
should this be an application? or library? take a look at [protobuf](https://github.com/hashgraph/hedera-block-node/blob/main/buildSrc/src/main/kotlin/com.hedera.block.protobuf.gradle.kts) build s...
AlfredoG87 created a review on a pull request on hashgraph/hedera-block-node
LG, leaved just some nits and questions.
AlfredoG87 created a review on a pull request on hashgraph/hedera-block-node
LG, leaved just some nits and questions.
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/251?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
ata-nas created a review comment on a pull request on hashgraph/hedera-block-node
Resolved, accepted method for that is we only use `@NonNull` or `@Nullable` from spotbugs and if there are any special requirements like not blank here, we must simply put in javadoc
ata-nas pushed 1 commit to 233-refactor-introduce-commons-module hashgraph/hedera-block-node
- resolved todo Signed-off-by: Atanas Atanasov <[email protected]> 2bc7987
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/258?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
codecov[bot] created a comment on a pull request on hashgraph/hedera-block-node
## [Codecov](https://app.codecov.io/gh/hashgraph/hedera-block-node/pull/258?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter...
AlfredoG87 opened a draft pull request on hashgraph/hedera-block-node
feat: cAdvisor Docker System Metrics and Dashboard for Dev Docker Stack
**Description**: - Improving Grafana configuration to remove login and need to change admin user - Added cAdvisor to Docker dev Stack to collect system metrics on host and containers - Added cAd...
AlfredoG87 created a branch on hashgraph/hedera-block-node
cadvisor-system-dashboard - New Block Node services
AlfredoG87 opened an issue on hashgraph/hedera-block-node
Add System Stat Metrics to the docker dev stack