Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it - thanks for the explanation!
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Casting is needed here to avoid the error: `Property 'length' does not exist on type 'never'.` TS has an annoying well documented behavior initially discussed here: https://github.com/microsoft/...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
It turns out casting is not required on this line given other changes. Why it was used initially will be explained in the comment below explaining why that line does need casting.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Yes, essentially the UI will be well aware of each attestation id value and these id values, as the attestations we are displaying on their respective pages are part of the design. Because of this,...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
It is intended to only be temporary, so I really don't want to add it as a config element. This should be an eye sore for us to rip out as soon as possible.
isabeleliassen opened an issue on csg-org/CompactConnect
redesign for licensee account creation page
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
OK, I think I have a better understanding from reading further down. Might it make sense to just add a brief comment on this model file explaining that this model technically models two versions of...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Can we document why we have to do this? (Is this standard in our codebase? It's possible I've just missed it in the past.)
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
why is casting required here?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
I'm confused by this comment - is this a comment on the function's logic, or broader conceptual documentation about the API? If the latter, can we hoist it up somewhere more appropriate - perhaps t...
jlkravitz created a review on a pull request on csg-org/CompactConnect
looks great! a few small nits.
jlkravitz created a review on a pull request on csg-org/CompactConnect
looks great! a few small nits.
isabeleliassen closed an issue on csg-org/CompactConnect
Design for "no errors" data validation email
isabeleliassen closed an issue on csg-org/CompactConnect
user invite design edits
- John to sync with Becca - refer to #189
isabeleliassen closed an issue on csg-org/CompactConnect
Licensee confirms their personal and licensure information (design update)
- none of this information should be editable - they provide an additional email to CompactConnect, so admins should be able to contact them at that email in addition to what they've provided to th...
isabeleliassen closed an issue on csg-org/CompactConnect
Read Permissions (frontend)
See #207 - update user invite and user permission edit UI (permission options increased when inviting user) - no need to update license search UI Updates below based on conversation between @...
isabeleliassen closed an issue on csg-org/CompactConnect
Read Permissions (frontend)
See #207 - update user invite and user permission edit UI (permission options increased when inviting user) - no need to update license search UI Updates below based on conversation between @...
isabeleliassen pushed 1 commit to development csg-org/CompactConnect
- Frontend/permission api updates (#428) ### Requirements List - _None_ ### Description List - Change compact-lev... 235c8ce
isabeleliassen closed a pull request on csg-org/CompactConnect
Frontend/permission api updates
### Requirements List - _None_ ### Description List - Change compact-level `read` permission to `readPrivate` - Add state-level `readPrivate` permission - Omit compact permission in server p...
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen Good to merge.