Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
isabeleliassen pushed 1 commit to development csg-org/CompactConnect
- Frontend/Fix pw input validation messages (#430) ### Requirements List - _None_ ### Description List - Move mes... 20f3115
isabeleliassen closed an issue on csg-org/CompactConnect
Password update validation bug
Path: `/Account` The validation messages are all 'green', but the box is red. It's not clear why. To reproduce, 1. Navigate to "Account" page 2. Enter current password (in my case, Josh12...
isabeleliassen closed a pull request on csg-org/CompactConnect
Frontend/Fix pw input validation messages
### Requirements List - _None_ ### Description List - Move message augmentation to after message evaluation - Update frontend to match latest backend pw requirements (length only) - Add test...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Yep. I think some updates to the swagger docs are coming soon. They got a little decoupled from the original code updates but are on their way. I think they'll also be accompanied by some testing /...
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen This is good to go.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it- thank you for the context!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ahh, ok. I guess that then begs the question as to why server endpoints may not be idempotent? That seems unnecessarily brittle. I am sure there are reasons beyond my understanding, but is that rea...
isabeleliassen closed an issue on csg-org/CompactConnect
practitioner registration backend and security assessment
- could require ID information to be entered when creating account
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
We generally try to avoid early returns. Also the default of `return { name: '' || null, date: '' };` it looks like `name` will always fallback to `null`. Overall is there a way to clean up the bod...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
As it stands, the "required" message is kind of awkward: <img width="722" alt="Screenshot 2025-01-10 at 9 23 11 AM" src="https://github.com/user-attachments/assets/38e93f95-edc4-449c-a49a-ff4bc770...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
It looks like we'll need to implement focus trapping to fully support keyboard nav. There's a recent example of this in the `SelectedStatePurchaseInformation` component. It's just a single method t...
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Functionality looks solid. Just a few trailing items that are pretty minor.
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Functionality looks solid. Just a few trailing items that are pretty minor.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
The board ED user situation is handled up near line ~365; to not have board EDs attempt to send those props at all, even if false. This section here is related to some testing & conversations we...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
The tests are just for the generic functionality of the low-level InputPassword component, so we know we can use them later if needed. You're correct that the app implementation in this ChangePa...
jsandoval81 created a comment on an issue on csg-org/CompactConnect
Per the latest standup, we'll also remove specific character requirements for now in order to align with the latest NIST recommendation.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Not intentional, though my form does seem to validate as I go. I'm going to add this in for the post submit functionality, as it irons out those wrinkles.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
That wasn't intentional in either place. I actually missed this in the SelectPrivileges form too. I'm not sure its important in this spot because there are no fields or success / failure message...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
I just added it, but its been working fine. I think it may either assume same params if not provided or only edit the url left as far as specified / necessary. I have a vague memory of reading a...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Was just a new color on the designs. I've deleted this here and replaced with @midRed in references to this