Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Why are we removing these requirements, yet still testing them below? (I know we had briefly discussed updated NIST guidelines several weeks ago - related? Generally, I'm keen to remove complexi...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
These variable renames are helpful to distinguish state and compact-level permissions!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
If I recall from discussions with Justin, I don't think this is really about idempotency. I believe the reason is because board ED users cannot change compact-level permissions, so any value (even ...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
If the API supported paging, these would at least trigger a re-fetch of the data. Does it make sense to have them just do that for now? If not, you could just have them `return false` & add comment...
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
jsandoval81 created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This is ready for your review.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Maybe, I was unsure about this. Essentially, the ListContainer component requires these functions be passed in as props. I didn't want to make those props non-required + change ListContainer log...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
No that's a total mistake. I didn't mean to delete that, good catch
jusdino created a review comment on a pull request on csg-org/CompactConnect
Can we leave the alarm and just remove the action? I'd like to still see the CloudWatch alarm if we go looking for it.
jusdino created a review comment on a pull request on csg-org/CompactConnect
Let's set a max length here
jusdino created a review on a pull request on csg-org/CompactConnect
Looks great! A couple of questions mostly:
jusdino created a review on a pull request on csg-org/CompactConnect
Looks great! A couple of questions mostly:
jusdino created a comment on an issue on csg-org/CompactConnect
Deferring full implementation till later. We're using this as a placeholder to represent the task of defining a more minimalist implementation for now.
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Looking solid 👍 This was a mostly code review. I'll take a deeper dive in the UI on the next pass.
jsandoval81 created a review on a pull request on csg-org/CompactConnect
Looking solid 👍 This was a mostly code review. I'll take a deeper dive in the UI on the next pass.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Minor: Move this to the `// Reds` section. Also, is this just a new color in the designs? Or did you have to create it to meet a11y? Ideally, we could use the same red we've been using for error...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Minor: The pattern up to now has been to declare computeds like stores, compact, user permissions & "high-level" things near the top of the computed block; as a means of making it easier to find in...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Does this need the `compact` param?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Minor: Prefer color variables.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Same as earlier comment - existing patterns seem to be just as effective, and not require `any`. Also, making sure `this.watchFormInputs()` is excluded on purpose.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
`isLoading` is probably meant to observe a different store here.