Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Ah, looks like that was copy/paste from the last test file I pulled over as a starting point. I'll remove it.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
To my understanding since UTC-4 is four hours behind UTC, if you want noon you would add four hours to 12 to determine the cron schedule, which is set according to the UTC time. I've confirmed thro...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Good call out, I've replaced the duplicate setup with a call to '_when_purchase_client_returns_paginated_transactions`
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
It ensures we don't process the same batch twice as we loop around the step function. I've updated the doc comment to include this detail.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
If this is deployed through CDK, that should never happen. We have this specific [condition check here](https://github.com/csg-org/CompactConnect/pull/420/files#diff-55a72343048a7d986bba49abcc44a43...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Where is this diagram located?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
If you wanted it to run at noon UTC-4, wouldn't hour be set to `8`?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
I'm a bit confused by this comment. What does this mean, and what are its implications for the code in this file?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What distinguishes this code from the setup code that's been abstracted away into `_when_purchase_client_returns_transactions`, etc?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What's the purpose of passing this list into this function?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
```suggestion # we'll have to allow the principal to use any SES identity configured in the account. ```
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Is there a way to organize the json files a little differently so we can avoid this one-off case?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What about the case where `FROM_ADDRESS` is not defined at all?
jlkravitz created a review on a pull request on csg-org/CompactConnect
Lookin' good. A few small comments/questions/nits. Hope you had a nice holiday and new year!
jlkravitz created a review on a pull request on csg-org/CompactConnect
Lookin' good. A few small comments/questions/nits. Hope you had a nice holiday and new year!