Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
small typo: "critical ~to~ for"
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Awesome, looks great!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah ok. I had to stare at this for a while to get that, but I think I understand now. Given what I think this all does, what do you think of simplifying this logic a bit as follows? I think some ver...
jlkravitz created a review on a pull request on csg-org/CompactConnect
@isabeleliassen This is good to go.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah, I missed the flipped sk/pk fields. Small nit, but can we just add a brief comment saying that to facilitate the reverse lookup, we reverse the primary and sort keys?
jusdino created a comment on a pull request on csg-org/CompactConnect
@jlkravitz, alrighty, this one is back in your court.
jusdino created a review comment on a pull request on csg-org/CompactConnect
Yeah, that's the fun of using polyglot libraries (and why I missed the typo in the first place). The library and its docs are written for TypeScript, but, when they get built for their target langu...
jusdino created a review comment on a pull request on csg-org/CompactConnect
That's what this function call is doing - declaring a GSI and defining its partition key, sort key, and projected attributes.
landonshumway-ia created a comment on a pull request on csg-org/CompactConnect
@jlkravitz This should now be ready for another review based on initial feedback. Thanks
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
I've pulled that in.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
same as above comment -- I've removed this section since it turns out we don't even support deleting users for now.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Discussed with @jusdino, and it looks like the system currently does not even support deleting users, so I have removed that entire detail for now to avoid confusion.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
I've rewritten the entire section to hopefully make the permissions model more explicit.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
After looking this over, I found another way to remove the brittleness of those tests while still assuring the necessary resources are created. I'll update the tests.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
I'll add a comment capturing this intent for brittleness
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Good catch, one of these tests is now redundant. In my initial implementation, the query endpoint was filtering based on permissions. However, during one of our standups it was determined that the ...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
yep good catch, leftover from my first implementation
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Unfortunately (or fortunately, depending on how you want to look at it), onboarding a new compact will require test changes, since we have tests that are explicitly checking IAM permission policies...