Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
Yes, but this is referring to the behavior of our other scopes, where if you are granted to fine-grain permission at the jurisdiction level, you are also granted the course-grain scope permission t...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
looks like an automated formatter change. I'll fix it.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
No not intentional, and I prefer your recommended approach. I'll pull it in.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah ok. If this understanding is correct, maybe we can update the comment to say "If We only need to suppress this if a role is being created for this lambda ```suggestion # Since this l...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it. That makes sense. Could we add a little more detail to this comment, if only to clarify that "organization access logging" means "AWS account event logging" (or similar)?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Or sorry-- I meant to say, "Where, if anywhere, is the _value_ of the GSI set? i.e., where it sets which field(s) are indexed." Maybe the answer is the same, still?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it! I trust you're right, but just confirming...it looks like the docs actually _do_ use `appliesTo`? https://github.com/cdklabs/cdk-nag
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Is it worth renaming one of these to make clear the distinction between them wrt caching? It seems `get_provider_user_auth_headers` only calls `get_user_tokens` if it doesn't already have a provide...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Perhaps worth adding a quick check to make sure at least (or exactly?) one provider is returned? (I realize this should never happen, but if/when a weird regression happens, a nice error message mi...
jlkravitz created a review on a pull request on csg-org/CompactConnect
Good stuff! Good documentation and testing all-around. A few comments and questions.
jlkravitz created a review on a pull request on csg-org/CompactConnect
Good stuff! Good documentation and testing all-around. A few comments and questions.
jusdino created a review comment on a pull request on csg-org/CompactConnect
[This ticket](https://github.com/orgs/csg-org/projects/1/views/7?pane=issue&itemId=91125439&issue=csg-org%7CCompactConnect%7C397) will probably involve creating an [organization trail](https://docs...
jusdino created a review comment on a pull request on csg-org/CompactConnect
Yes it should. Will fix.
jusdino created a review comment on a pull request on csg-org/CompactConnect
It doesn't yet. This index is one we will end up using in the future. I wanted to create it ahead of time so we didn't have to add an index to an existing table later on.
jusdino created a review comment on a pull request on csg-org/CompactConnect
Huh. Yes it is. Will fix.
jusdino created a review comment on a pull request on csg-org/CompactConnect
Yes, this was a typo I noticed while looking things over. The way these suppressions work is to basically 'turn off' any findings from the rule sets we are using that match the criteria of the supp...
jusdino created a review comment on a pull request on csg-org/CompactConnect
Oh, I can see that this would be confusing. In the case that `role` is `None`, a new role will be created for this particular lambda on construction. If `role` is not `None`, that means that a role...