Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jusdino created a comment on a pull request on csg-org/CompactConnect
@jlkravitz, new test case added ✅
landonshumway-ia created a comment on an issue on csg-org/CompactConnect
Capturing these details from sprint planning for future reference: - We will likely introduce an Attestations endpoint to get the latest attestations text, along with a unique id associated with t...
jlkravitz opened an issue on csg-org/CompactConnect
Destroy old CDK log groups
When I deploy my sandbox, it creates several log groups. When I run `cdk destroy "Sandbox/*"`, then deploy again, I would expect a clean deploy without extraneous resources in my AWS environment. I...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Sounds good. Once that's done, we can get this merged in, followed by #401
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Yeah I think so - the more we can abstract the complexity here away into a single place, the better. And then, if a comment is still needed, we can add one in one place.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Yeah I think that makes more sense from my perspective, and would clarify the variable's role!
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah that makes sense. Thanks for clarifying!
jusdino created a review comment on a pull request on csg-org/CompactConnect
Yeah, I'm anticipating that we will update the key structure and use the inverted key so that we can support both exchanging ssn->provider_id as well as provider_id->ssn
jsandoval81 created a comment on an issue on csg-org/CompactConnect
@jlkravitz This one is addressed in #383 (currently in CSG review).
jusdino created a review comment on a pull request on csg-org/CompactConnect
We could, though they are different because we are expecting different behaviors there: `data.pop(X, None)` will not produce a `KeyError` in the event that `X` is not in `data`, but `del data[X]` ...
jlkravitz opened an issue on csg-org/CompactConnect
UI Bug: "Viewing: undefined"
<img width="365" alt="image" src="https://github.com/user-attachments/assets/7d98d0d7-f7bb-417f-8efa-b38f1d278a3b" /> Steps to reproduce- 1. Log in as Board ED 2. Go to `/aslp/Licensing` 3....
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
## UI Bug <img width="365" alt="image" src="https://github.com/user-attachments/assets/7d98d0d7-f7bb-417f-8efa-b38f1d278a3b" /> Steps to reproduce- 1. Log in as Board ED 2. Go to `/aslp/L...
jusdino created a review comment on a pull request on csg-org/CompactConnect
Sure, adding this test case wouldn't hurt. I'll add it in.
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
If the pk and sk are the same, what is the purpose of the inverted GSI? Is the GSI going to be needed for future ssn work?
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
This detail is great in explaining how it is working, but I still don't understand why we need to avoid creating that dependency. Does it create a circular dependency between stacks? Could we make ...
landonshumway-ia created a review comment on a pull request on csg-org/CompactConnect
It would be useful to document here the purpose of this GSI and the access patterns it supports.
landonshumway-ia created a review on a pull request on csg-org/CompactConnect
Question about the inverted GSI that we will likely want to document the answer to.
landonshumway-ia created a review on a pull request on csg-org/CompactConnect
Question about the inverted GSI that we will likely want to document the answer to.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Wouldn't we want to instead (or additionally) test a permission structure like the below (all false)? Perhaps (1) create user with no permissions, (2) add permissions, (3) patch user with someth...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
For consistency, can we do this? ```suggestion data['jurisdictions'].pop(jurisdiction, None) ```