Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jlkravitz created a review on a pull request on csg-org/CompactConnect
One small comment, one question!
jlkravitz created a review on a pull request on csg-org/CompactConnect
One small comment, one question!
jsandoval81 created a comment on an issue on csg-org/CompactConnect
Consider adding a top level route at `/Privileges`. This has a few advantages: - Gives the main app nav router-link a parent path so the nav item can stay highlighted throughout the workflow - Act...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
`tokens.staff.AUTH_TYPE` and `tokens.licensee.AUTH_TYPE` both evaluate to the constant `auth_type`. This is a bit obfuscated with the current set up. Would the fix mentioned above "It might also...
jusdino opened a pull request on csg-org/CompactConnect
Test and fix empty action handling
### Requirements List - Bug fix for #412 ### Description List - Revised empty action handling in the staff-user permissions api Closes # #412
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
I could do that get once, save it to a variable and then refer to that variable. I could add a comment too explaining that they are the same value. It might also make more sense to move the auth...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Ok, Ill create a readme documenting the nuances of cognito, how our two user pool set up meshes with those nuances and explaining our mitigation efforts.
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Hmm, got it. So then why do you have to call `getItem` on both variables here, given they refer to the same thing?
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Got it. This is unintuitive enough that I think it might warrant documenting in a README. I think it might also make sense to document something on your other comment re: being logged in remotely v...
jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Ah- didn't know about that script. Helpful!
jusdino opened an issue on csg-org/CompactConnect
Fix backend staff user empty action handling
See [this sprint PR comment](https://github.com/csg-org/CompactConnect/pull/401#discussion_r1890640689) for details. It appears there are some holes in how the API is handling cases around when use...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Actually yes, the way `auth_storage` is evaluated `tokens.staff.AUTH_TYPE` and `tokens.licensee.AUTH_TYPE` are actually stored in exactly the same place as each other in session / local storage. ...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
Logged out from the perspective of cognito, not just locally. Local logout would be deleting the tokens. Remote logout would be making the tokens invalid / revoking them + removing http only cookies.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
We retain the access token from both user pools to maintain an indicator that we are still logged in to that user pool remotely. We need this indicator so that the app knows to remotely log the use...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
In the `logout_url` query param we specify where we want to be redirected to after visiting the hosted logout page. But, the `logout_url` we put there must be one of the allowed `logout_urls` liste...
jusdino opened a pull request on csg-org/CompactConnect
Feat/ssn table
### Description List - Added minor improvements to API/Lambda logging to make tracing requests easier - Moved SSN/provider_id association records into a separate DynamoDB table - Encrypted that ...