Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jusdino created a review on a pull request on csg-org/CompactConnect
Good to go! @jlkravitz , ready for you.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
I slacked you about this
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
String literal would be fine
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
No, I think I copy pasted code and didnt catch the misalignment
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
I can get rid of the if block with the changes, but getting rid of the casting causes alot of other issues.
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
No, I think I accidentally added a prop here deleted it and was cleaning up after myself. Later, looking at it I didn't feel like reverting the change was necessary as not having the trailing comma...
jusdino closed an issue on csg-org/CompactConnect
Add event records for license renewals, deactivations
Insurers and others will want to know, for a given day in the past, whether an individual was licensed to practice in a given jurisdiction. To do that we will need to present historical information...
ChiefStief created a review comment on a pull request on csg-org/CompactConnect
isLoadingOne triggers the loading overlay, isLoading does not. When the License Search page is loading the overlay doesn't pop up, the list itself has a loading spinner. I didn't want to affect ...
isabeleliassen pushed 1 commit to development csg-org/CompactConnect
- Feat/license event records (#434) ### Description List - Added `licenseUpdate` and `privilegeUpdate` record types ... a7e4f5e
isabeleliassen closed a pull request on csg-org/CompactConnect
Feat/license event records
### Description List - Added `licenseUpdate` and `privilegeUpdate` record types - Added change detection and update record creation on license ingest and privilege purchase processes - Updated p...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Just for my reference, how is `isLoadingOne` used differently than `isLoading` throughout the app?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Same question as previous.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Is this something that will expand later? Or can it just be a string literal at the call site?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
This is interesting. Was Vue complaining without the static prefix here?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
The computed is `affiliationType` but the inner return is `militaryStatus`. Is that intentional?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Same as previous comment about `alt` text. Seems fine to use the same ~"License section" text as before for all the cases on this page.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Negative margins are really dicey. They generally come back to bite when making updates. Is there an alternative here?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
If there's not a city, this looks like it will include the comma & space anyway. Is there a quick conditional we can perform to keep it cleaner? Maybe we also don't have to t deeply traverse `this....
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Does the outer computed name maybe make more sense as `militaryStatus` and the inner function body can use `status`?
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Same as previous comment.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
We can probably type these 2 props in more detail. They probably don't need separate models yet. Just something like: ``` previousValues?: { compactTransactionId?: string | null, date...
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
Same as previous comment.
jsandoval81 created a review comment on a pull request on csg-org/CompactConnect
This casting can probably go away if the updates to the model noted above are made. You may also be able to eliminate the `if` block by using `privilege.history?.forEach(` - or maybe with the updat...