Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dlloyd1-ch created a review comment on a pull request on companieshouse/limited-partnerships-api
The summary for the healthcheck still needs updating. It's not creating a registration submission. Suggest something like: `Health check URL returns 200 if service is running`
mattch1 created a review comment on a pull request on companieshouse/limited-partnerships-api
Updated to say "get"
mattch1 pushed 1 commit to lp-119-intial-api-spec companieshouse/limited-partnerships-api
- hc endpoint should be a get 2726241
dlloyd1-ch created a review comment on a pull request on companieshouse/limited-partnerships-api
Needs changing to "get". Also the summary needs updating.
mattch1 created a review comment on a pull request on companieshouse/limited-partnerships-api
Cut this back.
mattch1 pushed 1 commit to lp-119-intial-api-spec companieshouse/limited-partnerships-api
- Cut back spec to show only the healthcheck endpoint c983c95
mwestacott created a review comment on a pull request on companieshouse/limited-partnerships-api
I think only the healthcheck end-point should feature in the spec for the moment. We add the others when we come to implement the end-points in controllers.
mattch1 created a review comment on a pull request on companieshouse/limited-partnerships-api
Updated spec endpoint using a hyphen for limited-partnership.
mattch1 created a review comment on a pull request on companieshouse/limited-partnerships-api
Updated to use the actuator by adding application.properties config.
mattch1 pushed 1 commit to lp-119-intial-api-spec companieshouse/limited-partnerships-api
- Use actuator for the healthcheck endpoint 808e8ad
mattch1 created a comment on a pull request on companieshouse/limited-partnerships-api
Updated the schema to reflect https://companieshouse.atlassian.net/wiki/spaces/Arch/pages/4722491429/LP+Service+Design As we do not have schema details yet that will have to be added later.
mattch1 pushed 1 commit to lp-119-intial-api-spec companieshouse/limited-partnerships-api
- LP-119 Update schema to reflect design document. 86cb1b4
dlloyd1-ch created a review comment on a pull request on companieshouse/limited-partnerships-api
Ideally the initial spec should just have a healthcheck endpoint which is `/limited_partnership/healthcheck` according to the service design doc: https://companieshouse.atlassian.net/wiki/spaces/Ar...
mwestacott created a review comment on a pull request on companieshouse/limited-partnerships-api
Yes, so that's the end-point you added to the controller but I don't think the health-check end-point will be working - that requires actuator config which is missing. We can have a call.
mattch1 created a review comment on a pull request on companieshouse/limited-partnerships-api
 The endpoint does work, surprised this has it's own config though. I can...
markpit created a comment on a pull request on companieshouse/limited-partnerships-api
In the Dev workshop earlier, Mike's design document has the endpoints with /limited-partnership/ (no s) https://companieshouse.atlassian.net/wiki/spaces/Arch/pages/4722491429/LP+Service+Design
mwestacott created a review comment on a pull request on companieshouse/limited-partnerships-api
Ah right, I see. But... is the health-check end-point working on that URL? For ROE we added [this](https://github.com/companieshouse/overseas-entities-api/blob/main/src/main/resources/applicatio...
mattch1 created a review comment on a pull request on companieshouse/limited-partnerships-api
This is not the create endpoint it is just the health check. I was following what we did for roe based on the advice on the ticket, we don't tend to put health checks in the spec and it needed some...