Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mattch1 created a comment on a pull request on companieshouse/limited-partnerships-api
Updated the schema to reflect https://companieshouse.atlassian.net/wiki/spaces/Arch/pages/4722491429/LP+Service+Design As we do not have schema details yet that will have to be added later.
mattch1 pushed 1 commit to lp-119-intial-api-spec companieshouse/limited-partnerships-api
- LP-119 Update schema to reflect design document. 86cb1b4
dlloyd1-ch created a review comment on a pull request on companieshouse/limited-partnerships-api
Ideally the initial spec should just have a healthcheck endpoint which is `/limited_partnership/healthcheck` according to the service design doc: https://companieshouse.atlassian.net/wiki/spaces/Ar...
mwestacott created a review comment on a pull request on companieshouse/limited-partnerships-api
Yes, so that's the end-point you added to the controller but I don't think the health-check end-point will be working - that requires actuator config which is missing. We can have a call.
mattch1 created a review comment on a pull request on companieshouse/limited-partnerships-api
 The endpoint does work, surprised this has it's own config though. I can...
markpit created a comment on a pull request on companieshouse/limited-partnerships-api
In the Dev workshop earlier, Mike's design document has the endpoints with /limited-partnership/ (no s) https://companieshouse.atlassian.net/wiki/spaces/Arch/pages/4722491429/LP+Service+Design
mwestacott created a review comment on a pull request on companieshouse/limited-partnerships-api
Ah right, I see. But... is the health-check end-point working on that URL? For ROE we added [this](https://github.com/companieshouse/overseas-entities-api/blob/main/src/main/resources/applicatio...
mattch1 created a review comment on a pull request on companieshouse/limited-partnerships-api
This is not the create endpoint it is just the health check. I was following what we did for roe based on the advice on the ticket, we don't tend to put health checks in the spec and it needed some...
mwestacott created a review comment on a pull request on companieshouse/limited-partnerships-api
The controller POST end-point currently seems to map to just the root path ("/") so is this right, having "/limited-partnerships"?
mattch1 created a review comment on a pull request on companieshouse/limited-partnerships-api
Cut and past error. removed extra word.
mattch1 pushed 1 commit to lp-119-intial-api-spec companieshouse/limited-partnerships-api
- LP-119 Typo 13523de
mwestacott created a review comment on a pull request on companieshouse/limited-partnerships-api
Minor "...to allow the registration..."
mattch1 opened a pull request on companieshouse/limited-partnerships-api
LP-119 Add initial api spec
Jira: https://companieshouse.atlassian.net/browse/LP-119 Add spec with supposed create endpoint, this is based on the initialisation of the spec for roe. Added mongo, related timezone post co...
mattch1 created a review comment on a pull request on companieshouse/limited-partnerships-api
This looks like it relates to mongo but as there is no mongo specific task for the api I can add this tot he next api PR.
mattch1 created a branch on companieshouse/limited-partnerships-api
lp-119-intial-api-spec - API for the Limited Partnerships service
mwestacott created a review comment on a pull request on companieshouse/limited-partnerships-api
We shouldn't forget to do this, which is in the equivalent ROE class: ``` @PostConstruct public void init() { // This is to prevent times being out of time by an hour during B...
mattch1 pushed 2 commits to main companieshouse/limited-partnerships-api
mattch1 closed a pull request on companieshouse/limited-partnerships-api
LP-111 create a basic spring boot api
https://companieshouse.atlassian.net/browse/LP-111 Mavenized the project Then manually added spring boot modules to POM: - spring-boot-starter-web - spring-boot-starter-actuator - spring...
mwestacott created a comment on a pull request on companieshouse/limited-partnerships-api
> Mavenized the project > > Then manually added spring boot modules to POM: > > * spring-boot-starter-web > * spring-boot-starter-actuator > * spring-boot-starter-test > > based on ROE b...
mattch1 opened a pull request on companieshouse/limited-partnerships-api
LP-111 create a basic spring boot api
Mavenized the project Add spring boot modules to POM: - spring-boot-starter-web - spring-boot-starter-actuator - spring-boot-starter-test Added the plugin Added a main app class Adde...