Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

RedHatInsights/insights-chrome

epwinchell opened a pull request on RedHatInsights/insights-chrome
Service dropdown updates
- Update left side styling Old <img width="348" alt="Screenshot 2025-02-13 at 5 13 12 PM" src="https://github.com/user-attachments/assets/82d9e938-96a4-4369-a489-589a63e1eb26" /> New <img w...
florkbr closed a pull request on RedHatInsights/insights-chrome
Update PatternFly to v6
This PR updates the repo to use PatternFly v6 as well as upstream PF consuming packages which have already been migrated.
florkbr created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

Hyperkid123 created a review comment on a pull request on RedHatInsights/insights-chrome
@catastrophe-brandon @JetyAdam there already is a cypress component test like that. We should just expand the cases. https://github.com/RedHatInsights/insights-chrome/blob/master/cypress/compone...

View on GitHub

Hyperkid123 created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

Hyperkid123 created a review comment on a pull request on RedHatInsights/insights-chrome
I think clearing the timeout and canceling the preload is not necessary. I argue that it is even unwanted. A preload happens only once for a module. Then the bundle is in the browser and in the...

View on GitHub

Hyperkid123 created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

florkbr created a comment on a pull request on RedHatInsights/insights-chrome
/ok-to-test

View on GitHub

florkbr pushed 4 commits to master RedHatInsights/insights-chrome
  • Fix bug preventing permission error message from appearing 6b1e2bc
  • Merge branch 'master' into fix_export_hold_err 7a36a2f
  • Merge branch 'master' into fix_export_hold_err 6066653
  • Merge pull request #3011 from JetyAdam/fix_export_hold_err Fix bug preventing permission error message from appearing a5e13ae

View on GitHub

florkbr closed a pull request on RedHatInsights/insights-chrome
Fix bug preventing permission error message from appearing
GatewayErrorComponent wasn't rendered in some edge cases. https://issues.redhat.com/browse/RHCLOUD-37729
florkbr created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

florkbr created a comment on a pull request on RedHatInsights/insights-chrome
Since this is effecting end users and we have our PF6 release tomorrow - I'm going to merge. We can follow up on the test plan ASAP.

View on GitHub

florkbr pushed 1 commit to master RedHatInsights/insights-chrome
  • Update itless apps in AllServices page (#3002) * Updated ITLess flag for apps * Removed ITLess logic for AllServi... a063b3d

View on GitHub

florkbr created a comment on a pull request on RedHatInsights/insights-chrome
/retest

View on GitHub

florkbr created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

florkbr closed a pull request on RedHatInsights/insights-chrome
Remove Satellite from header in itless env
Want to remove itless from the header in itless environment Will be moved to the side nav: [Here](https://github.com/RedHatInsights/chrome-service-backend/pull/771)
florkbr created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

JetyAdam created a review comment on a pull request on RedHatInsights/insights-chrome
@catastrophe-brandon I think that it would be possible to set up a unit test.

View on GitHub

JetyAdam created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

JetyAdam created a review comment on a pull request on RedHatInsights/insights-chrome
@florkbr You are right. I updated the if statement.

View on GitHub

JetyAdam created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

florkbr commented on a commit on RedHatInsights/insights-chrome
/retest

View on GitHub

catastrophe-brandon created a review comment on a pull request on RedHatInsights/insights-chrome
I may not be using the right vernacular - if it's not a unit test it could be a component test. Something that doesn't require a fully-built end-to-end environment to execute.

View on GitHub

catastrophe-brandon created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

catastrophe-brandon created a review comment on a pull request on RedHatInsights/insights-chrome
Just spitballing here - would it be possible to set up some sort of a unit test with a mocked config/response? Essentially mock up a scenario with a fake user that causes a gateway error, then we c...

View on GitHub

catastrophe-brandon created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

florkbr created a review comment on a pull request on RedHatInsights/insights-chrome
@JetyAdam this is also missing tests. I think this is a perfect case to have test automation for as it impacts so many users - but is very rare for devs to experience regularly. Can we open a f...

View on GitHub

florkbr created a review on a pull request on RedHatInsights/insights-chrome

View on GitHub

florkbr created a review comment on a pull request on RedHatInsights/insights-chrome
@JetyAdam this seems a bit untidy to me. We could have: ```tsx if (!configLoaded) { return gatewayError ? <GatewayErrorComponent error={gatewayError} serviceName="Hybrid Cloud Console" /...

View on GitHub

Load more