Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
danielcdz created a comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
In some comments you are using `///` and in other `//` can you update all of them to be just `//`?
danielcdz created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
this also can be avoided
danielcdz created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
Can you move to the top of the test? place it in line 40, in most of this tests for models we do testing for the initialization of the model, so I think is better to leave it on the top level
danielcdz created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
this can be avoided
danielcdz created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
can you replace the word `struct` to `model`?
danielcdz created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
Can you change this to be on top of the function definition, for example: ``` rust // Executes an attack fn attack(ref world: IWorldDispatcher, battle_id: u32, mt_id: u32); // Use...
danielcdz created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
this can be avoided
danielcdz created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
for imports we can avoid the comments since are very intuitive
danielcdz created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
great, thank you!
coxmars created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
Hi @josephpdf, please use the following structure for this Pull Request Template: ## Pull Request Overview ### 📝 Summary - Closes # number issue - Brief summary ### 🔄 Changes Made - Add ch...
coxmars created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
Hi @josephpdf, please update this file CONTRIBUTION.md by adding the content/file from: [Contribution Guidelines](https://github.com/ByteBuildersLabs/ByteBeastsBackend/blob/main/CONTRIBUTION.md) Th...
coxmars created a comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
Hi @cristianFleita, I tested the pre-push hook and it looks good. Great job this will be really helpful! 🚀
coxmars created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
Same applies here
coxmars created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
@KevinMB0220, please keep the existing comments as they serve as a guide for future improvements in specific sections. You can add any new comments alongside them.
KevinMB0220 opened a draft pull request on ByteBuildersLabs/ByteBeastsBackend
feat-documentation
## Pull Request Overview ### 📝 Summary - Closes #(issue) - ### 🔄 Changes Made - ### 🔧 Tests Results - ### 🔜 Next Steps - PoC inicial
cristianFleita created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
That happens because each time you run `make setup`, the command `rm -rf "manifests"` is executed, which removes the manifest directory. We previously encountered issues with the manifest, and this...
josephpdf created a comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
> @josephpdf Can you translate the PR description steps you added to English, please? I was wrong, but I already changed the language.
josephpdf created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
I have already changed the file name.
danielcdz created a review comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
why did you delete these files? just out of curiosity, if they are not required do you think is a good idea to include them in a .gitignore?
danielcdz created a comment on a pull request on ByteBuildersLabs/ByteBeastsBackend
awesome @cristianFleita ! 🚀 we are testing this but it looks pretty good overall, thank you!