Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
BrianWhitneyAI closed a pull request on AllenInstitute/biofile-finder
feature/derive_local_path
### Description The purpose of this PR is to resolve #390. When working with the ETL it became apparent that having an annotation with a unique value for each file puts a lot of stress on the ann...
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- remove test env change e7592a7
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- try to update renderer 98c1eca
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- try to update test env 4ebcb08
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- try new test script config 3628f0b
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
resolved in [41c48db](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/41c48db32edf9182ac477cd73ffb16de9f0a64f4)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
resilved in [41c48db](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/41c48db32edf9182ac477cd73ffb16de9f0a64f4)
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- minor edits 41c48db
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
oh Im wrong. We already check in localPath for this. setting to null.
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Resolved in [03c770b](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/03c770bc20447a5d27bbb7dde49360e254854308)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
for record. Consensus was env is used elsewhere and should remain
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
This is for backwards compatibility. Right now its possible this.path is '/allen' in this case we want to return it.
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
We dont have labkey download for staging files I believe so this function default returns the cloud path for the staging file which can be downloaded
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
Perhaps if you are introducing env dependent variables to this class then there should be a case for `this.env === Environment.STAGING` where the return is: `return `http://stg-aics.corp.alleninst...
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
Is this `null` or the cloud path at this point? If `null` can you return `null` here explicitly & if it is the cloud path can you keep the comment above?
SeanLeRoy created a review comment on a pull request on AllenInstitute/biofile-finder
My main issue with this isn't the usage of `localPath` as a property but that `env` is being passed in as a property to this class when it could just be a parameter to `getLocalPath`
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- update test:desktop script 6a6b2c8
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- Add backwards compat 03c770b
kmitcham created a comment on a pull request on AllenInstitute/biofile-finder
> Philip brought up that we could derive from the Cloud path as well which would be much simpler. I opted against this idea since the cloud path is already derived from fms-ID. Open to a discussion...
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
In regards to `Cache Eviction Date` I don't think that we should use this yet since it has not been backfilled and will only show up on new annotations. We would not reach a state where the file pa...